[evolvis-commits] r6505: - Optimized download.class.php

papel at evolvis.org papel at evolvis.org
Thu Apr 1 13:20:23 CEST 2010


Author: papel
Date: 2010-04-01 11:20:22 +0000 (Thu, 01 Apr 2010)
New Revision: 6505

Modified:
   trunk/gforge_base/gforge-4.8.1+evolvis/www/frs/download.class.php
Log:
- Optimized download.class.php

Modified: trunk/gforge_base/gforge-4.8.1+evolvis/www/frs/download.class.php
===================================================================
--- trunk/gforge_base/gforge-4.8.1+evolvis/www/frs/download.class.php	2010-04-01 09:47:25 UTC (rev 6504)
+++ trunk/gforge_base/gforge-4.8.1+evolvis/www/frs/download.class.php	2010-04-01 11:20:22 UTC (rev 6505)
@@ -8,34 +8,75 @@
 
 class download extends Error {
 	
-	var $uploaddir_, $group_, $package_, $release_;  
+	private $uploaddir_, $group_, $package_, $release_;  
 
-	public function download($uploaddir=null, $group=null, $package=null, $release=null,  $file=null){
-		global $uploaddir_, $group_, $package_, $release_;
-		
-			$uploaddir_ = $uploaddir;
-			$group_ = $group;
-			$package_ = $package;
-			$release_ = $release;	
+	public function download($uploaddir=null, $group=null, $package=null, $release=null){
+			$this->uploaddir_ = $uploaddir;
+			$this->group_ = $group;
+			$this->package_ = $package;
+			$this->release_ = $release;
 	}
 	
-	public function getNewestReleasePathAsString(){	
-		global $uploaddir_, $group_, $package_, $release_;
+	public function getUploadDir(){
+		return $this->uploaddir_;
+	}
+	
+	public function getGroupObject(){
+		return $this->group_;
+	}
+	
+	public function getPackageObject(){
+		return $this->package_;	
+	}
+	
+	public function getReleaseObject(){
+		return $this->release_;	
+	}
+	
+	public function setUploadDir($uploaddir){
+		$this->uploaddir_ = $uploaddir;
+	}
+	
+	public function setGroupObject($group){
+		$this->group_ = $group;
+	}
+	
+	public function setPackageObject($package){
+		$this->package_ = $package;
+	}
+	
+	public function setReleaseObject($release){
+		$this->release_ = $release;
+	}
+		
+	public function getNewestReleasePathAsString(){			
+		$uploaddir_ = $this->getUploadDir();
+		$group_ = $this->getGroupObject();
+		$package_ = $this->getPackageObject(); 
+		$release_ = $this->getReleaseObject();
+		
    	  	return $newestReleasePathAsString = $uploaddir_ .$group_->getUnixName().'/'.$package_->getFileName().'/'.$release_->getFileName();
 	}	
 	
 	public function getPackagePathAsString(){
-		global $uploaddir_, $group_, $package_, $release_;
+		$uploaddir_ = $this->getUploadDir();
+		$group_ = $this->getGroupObject();
+		$package_ = $this->getPackageObject(); 
+
 		return $uploaddir_.$group_->getUnixName().'/'.$package_->getFileName();
 	}
 	
 	function getNewestReleaseAsStandardFileName() {
-		global $package_;
+		$package_ = $this->getPackageObject(); 
+
 		return $package_->getFileName()."Release.zip";
 	}
 	
 	public function createNewestReleaseFilesAsZip(){
-		global $uploaddir_, $group_, $package_, $release_;
+		$uploaddir_ = $this->getUploadDir();
+		$group_ = $this->getGroupObject();
+		$package_ = $this->getPackageObject(); 
+		$release_ = $this->getReleaseObject();
 		
 		$zip = new ZipArchive();
 




More information about the evolvis-commits mailing list