[evolvis-commits] r6828: can it really be so hard to code proper XHTML? no!↵

mirabilos at evolvis.org mirabilos at evolvis.org
Tue Jul 27 17:26:31 CEST 2010


Author: mirabilos
Date: 2010-07-27 17:26:31 +0200 (Tue, 27 Jul 2010)
New Revision: 6828

Modified:
   trunk/gforge_base/evolvisforge/gforge/common/docman/Document.class.php
   trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentFactory.class.php
   trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentGroup.class.php
   trunk/gforge_base/evolvisforge/gforge/common/forum/Forum.class.php
   trunk/gforge_base/evolvisforge/gforge/common/forum/ForumMessage.class.php
   trunk/gforge_base/evolvisforge/gforge/common/frs/FRSFile.class.php
   trunk/gforge_base/evolvisforge/gforge/common/frs/FRSPackage.class.php
   trunk/gforge_base/evolvisforge/gforge/common/frs/FRSRelease.class.php
   trunk/gforge_base/evolvisforge/gforge/common/include/Group.class.php
   trunk/gforge_base/evolvisforge/gforge/common/include/GroupJoinRequest.class.php
   trunk/gforge_base/evolvisforge/gforge/common/include/RoleObserver.class.php
   trunk/gforge_base/evolvisforge/gforge/common/include/User.class.php
   trunk/gforge_base/evolvisforge/gforge/common/mail/MailingList.class.php
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectCategory.class.php
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectGroup.class.php
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTaskFactory.class.php
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTasksForUser.class.php
   trunk/gforge_base/evolvisforge/gforge/common/survey/Survey.class.php
   trunk/gforge_base/evolvisforge/gforge/common/survey/SurveyQuestion.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactBoxOptions.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactCanned.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraField.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraFieldElement.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFactory.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFile.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFromID.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactHistory.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactMessage.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactQuery.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactType.class.php
   trunk/gforge_base/evolvisforge/gforge/cronjobs/massmail.php
   trunk/gforge_base/evolvisforge/gforge/debian/changelog
   trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/svn-stats.php
   trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/update_users.php
   trunk/gforge_base/evolvisforge/gforge/plugins/wiki/common/WikiPlugin.class.php
   trunk/gforge_base/evolvisforge/gforge/www/activity/index.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/add_task.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/browse_task.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectGroupHTML.class.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/include/pm_columns.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/mod_task.php
   trunk/gforge_base/evolvisforge/gforge/www/pm/t_follow.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/add.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addcanned.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafield.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafieldoption.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-clonetracker.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-deleteextrafield.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-extrafieldcopy.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatecanned.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updateextrafield.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatetracker.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/ind.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/browse.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/downloadcsv.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/mod.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/query.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/reporting/index.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/tracker.php
   trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategory.class.php
   trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategoryLabel.class.php
Log:
can it really be so hard to code proper XHTML? no!


Modified: trunk/gforge_base/evolvisforge/gforge/common/docman/Document.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/docman/Document.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/docman/Document.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -196,7 +196,7 @@
 			$this->setError(_('Document:: Invalid docid'));
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentFactory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentFactory.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentFactory.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -228,7 +228,7 @@
 			$this->setError(_('No Documents Found')." ".db_error());
 			return false;
 		} else {
-			while ($arr =& db_fetch_array($result)) {
+			while ($arr = db_fetch_array($result)) {
 				$this->Documents[] = new Document($this->Group, $arr['docid'], $arr);
 			}
 		}
@@ -247,7 +247,7 @@
 			exit_error('Error', db_error());
 		}
 		
-		while ($arr =& db_fetch_array($result)) {
+		while ($arr = db_fetch_array($result)) {
 			$doc_group_id = $arr['doc_group'];
 			if (!is_array(@$this->Documents[$doc_group_id])) {
 				$this->Documents[$doc_group_id] = array();

Modified: trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentGroup.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentGroup.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/docman/DocumentGroup.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -152,7 +152,7 @@
 			$this->setError(_('DocumentGroup: Invalid DocumentGroup ID'));
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/forum/Forum.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/forum/Forum.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/forum/Forum.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -233,7 +233,7 @@
 			$this->setError(_('Invalid forum group identifier'));
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/forum/ForumMessage.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/forum/ForumMessage.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/forum/ForumMessage.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -407,7 +407,7 @@
 			$this->setError(_('ForumMessage::fetchData() Invalid MessageID').db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}
@@ -426,7 +426,7 @@
 			$this->setError(_('ForumMessage::fetchData() Invalid MessageID').db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/frs/FRSFile.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/frs/FRSFile.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/frs/FRSFile.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -216,7 +216,7 @@
 			$this->setError('FRSFile::fetchData()  Invalid file_id');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/frs/FRSPackage.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/frs/FRSPackage.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/frs/FRSPackage.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -58,7 +58,7 @@
 				$FRSPACKAGE_OBJ['_'.$package_id.'_']=false;
 				return false;
 			}
-			$data =& db_fetch_array($res);			
+			$data = db_fetch_array($res);			
 		}
 		$Group =& group_get_object($data['group_id']);
 		$FRSPACKAGE_OBJ['_'.$package_id.'_']= new FRSPackage($Group,$data['package_id'],$data);

Modified: trunk/gforge_base/evolvisforge/gforge/common/frs/FRSRelease.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/frs/FRSRelease.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/frs/FRSRelease.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -45,7 +45,7 @@
 				$FRSRELEASE_OBJ['_'.$release_id.'_']=false;
 				return false;
 			}
-			$data =& db_fetch_array($res);
+			$data = db_fetch_array($res);
 		}
 		$FRSPackage =& frspackage_get_object($data['package_id']);
 		$FRSRELEASE_OBJ['_'.$release_id.'_']= new FRSRelease($FRSPackage,$data['release_id'],$data);

Modified: trunk/gforge_base/evolvisforge/gforge/common/include/Group.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/include/Group.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/include/Group.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -132,7 +132,7 @@
 	if (count($fetch) > 0) {
 		$res=db_query_params ('SELECT * FROM groups WHERE group_id = ANY ($1)',
 				      array (db_int_array_to_any_clause ($fetch))) ;
-		while ($arr =& db_fetch_array($res)) {
+		while ($arr = db_fetch_array($res)) {
 			$GROUP_OBJ["_".$arr['group_id']."_"] = new Group($arr['group_id'],$arr);
 			$return[] =& $GROUP_OBJ["_".$arr['group_id']."_"];
 		}
@@ -2009,7 +2009,7 @@
 		if (!isset($this->membersArr)) {
 			$res = db_query_params ('SELECT users.* FROM users INNER JOIN user_group ON users.user_id=user_group.user_id WHERE user_group.group_id=$1',
 						array ($this->getID())) ;
-			while ($arr =& db_fetch_array($res)) {
+			while ($arr = db_fetch_array($res)) {
 				$this->membersArr[] = new GFUser($arr['user_id'],$arr);
 			}
 		}

Modified: trunk/gforge_base/evolvisforge/gforge/common/include/GroupJoinRequest.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/include/GroupJoinRequest.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/include/GroupJoinRequest.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -162,7 +162,7 @@
 	                $this->setError('GroupJoinRequest::fetchData() Invalid ID '.db_error());
 	                return false;
 			}
-	        $this->data_array =& db_fetch_array($res);
+	        $this->data_array = db_fetch_array($res);
 	        db_free_result($res);
 	        return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/include/RoleObserver.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/include/RoleObserver.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/include/RoleObserver.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -89,7 +89,7 @@
 		//
 		$res = db_query_params ('SELECT group_forum_id,is_public,allow_anonymous FROM forum_group_list WHERE group_id=$1',
 					array ($this->Group->getID())) ;
-		while ($arr =& db_fetch_array($res)) {
+		while ($arr = db_fetch_array($res)) {
 			$this->setting_array['forumpublic'][$arr['group_forum_id']] = $arr['is_public'];
 			$this->setting_array['forumanon'][$arr['group_forum_id']] = $arr['allow_anonymous'];
 		}
@@ -99,7 +99,7 @@
 		//
 		$res = db_query_params ('SELECT group_project_id,is_public FROM project_group_list WHERE group_id=$1',
 					array ($this->Group->getID())) ;
-		while ($arr =& db_fetch_array($res)) {
+		while ($arr = db_fetch_array($res)) {
 			$this->setting_array['pmpublic'][$arr['group_project_id']] = $arr['is_public'];
 		}
 
@@ -108,7 +108,7 @@
 		//
 		$res = db_query_params ('SELECT group_artifact_id,is_public,allow_anon FROM artifact_group_list WHERE group_id=$1',
 					array ($this->Group->getID())) ;
-		while ($arr =& db_fetch_array($res)) {
+		while ($arr = db_fetch_array($res)) {
 			$this->setting_array['trackerpublic'][$arr['group_artifact_id']] = $arr['is_public'];
 			$this->setting_array['trackeranon'][$arr['group_artifact_id']] = $arr['allow_anon'];
 		}
@@ -118,7 +118,7 @@
 		//
 		$res = db_query_params ('SELECT package_id,is_public FROM frs_package WHERE group_id=$1',
 					array ($this->Group->getID())) ;
-		while ($arr =& db_fetch_array($res)) {
+		while ($arr = db_fetch_array($res)) {
 			$this->setting_array['frspackage'][$arr['package_id']] = $arr['is_public'];
 		}
 

Modified: trunk/gforge_base/evolvisforge/gforge/common/include/User.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/include/User.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/include/User.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -100,7 +100,7 @@
 	if (count($fetch) > 0) {
 		$res = db_query_params ('SELECT * FROM users WHERE user_id = ANY ($1)',
 					array (db_int_array_to_any_clause ($fetch))) ;
-		while ($arr =& db_fetch_array($res)) {
+		while ($arr = db_fetch_array($res)) {
 			$USER_OBJ["_".$arr['user_id']."_"] = new GFUser($arr['user_id'],$arr);
 			$return[] =& $USER_OBJ["_".$arr['user_id']."_"];
 		}
@@ -557,7 +557,7 @@
 			$this->setError('GFUser::fetchData()::'.db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		return true;
 	}
 	

Modified: trunk/gforge_base/evolvisforge/gforge/common/mail/MailingList.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/mail/MailingList.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/mail/MailingList.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -217,7 +217,7 @@
 			$this->setError(sprintf(_('Error Getting %1$s'), _('Error Getting %1$s')));
 			return false;
 		}
-		$this->dataArray =& db_fetch_array($res);
+		$this->dataArray = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectCategory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectCategory.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectCategory.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -136,7 +136,7 @@
 			$this->setError('ProjectCategory: Invalid ProjectCategory ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectGroup.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectGroup.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectGroup.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -46,7 +46,7 @@
 					$PROJECTGROUP_OBJ["_".$group_project_id."_"]=false;
 					return false;
 				}
-				$data =& db_fetch_array($res);
+				$data = db_fetch_array($res);
 			}
 			$Group =& group_get_object($data["group_id"]);
 			$PROJECTGROUP_OBJ["_".$group_project_id."_"]= new ProjectGroup($Group,$group_project_id,$data);
@@ -215,7 +215,7 @@
 			$this->setError('ProjectGroup:: Invalid group_project_id');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -40,7 +40,7 @@
 					$PROJECTTASK_OBJ["_".$project_task_id."_"]=false;
 					return false;
 				}
-				$data =& db_fetch_array($res);
+				$data = db_fetch_array($res);
 
 			}
 			$ProjectGroup =& projectgroup_get_object($data["group_project_id"]);
@@ -260,7 +260,7 @@
 			$this->setError('ProjectTask::fetchData() Invalid Task ID'.db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTaskFactory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTaskFactory.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTaskFactory.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -193,7 +193,7 @@
 		}
 
 		$this->project_tasks = array();
-		while ($arr =& db_fetch_array($result)) {
+		while ($arr = db_fetch_array($result)) {
 			if ($this->status && ($this->status != 100)) {
 				if ($this->status == 1) {
 					if ($arr['status_id'] != 1 && $arr['status_id'] != 100)

Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTasksForUser.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTasksForUser.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTasksForUser.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -61,7 +61,7 @@
 		$rows=db_numrows($result);
 		for ($i=0; $i < $rows; $i++) {
 			$project_task_id = db_result($result,$i,'project_task_id');
-			$arr =& db_fetch_array($result);
+			$arr = db_fetch_array($result);
 			$task =& projecttask_get_object($project_task_id,$arr);
 			$tasks[] =& $task;
 		}

Modified: trunk/gforge_base/evolvisforge/gforge/common/survey/Survey.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/survey/Survey.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/survey/Survey.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -246,7 +246,7 @@
 			$this->setError(_('No Survey is found').db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/survey/SurveyQuestion.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/survey/SurveyQuestion.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/survey/SurveyQuestion.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -194,7 +194,7 @@
 			$this->setError(_('Error finding question').db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -51,7 +51,7 @@
 					$ARTIFACT_OBJ["_".$artifact_id."_"]=false;
 					return false;
 				}
-				$data =& db_fetch_array($res);
+				$data = db_fetch_array($res);
 			}
 			$ArtifactType =& artifactType_get_object($data["group_artifact_id"]);
 			$ARTIFACT_OBJ["_".$artifact_id."_"]= new Artifact($ArtifactType,$data);
@@ -292,7 +292,7 @@
 			$this->setError('Artifact: Invalid ArtifactID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactBoxOptions.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactBoxOptions.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactBoxOptions.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -134,7 +134,7 @@
 			$this->setError('ArtifactSelectionBox: Invalid Artifact ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactCanned.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactCanned.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactCanned.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -133,7 +133,7 @@
 			$this->setError('ArtifactCanned: Invalid ArtifactCanned ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraField.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraField.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraField.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -220,7 +220,7 @@
 			$this->setError('ArtifactExtraField: Invalid ArtifactExtraField ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraFieldElement.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraFieldElement.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactExtraFieldElement.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -146,7 +146,7 @@
 			$this->setError('ArtifactExtraField: Invalid ArtifactExtraFieldElement ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFactory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFactory.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFactory.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -365,7 +365,7 @@
 			$this->setError('Database Error: '.db_error());
 			return false;
 		} else {
-			while ($arr =& db_fetch_array($result)) {
+			while ($arr = db_fetch_array($result)) {
 				$this->artifacts[] = new Artifact($this->ArtifactType, $arr);
 			}
 		}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFile.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFile.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFile.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -44,7 +44,7 @@
 				$ARTIFACTFILE_OBJ["_".$artifact_file_id."_"]=false;
 				return false;
 			}
-			$data =& db_fetch_array($res);
+			$data = db_fetch_array($res);
 		}
 		$Artifact =& artifact_get_object($data["artifact_id"]);
 		$ARTIFACTFILE_OBJ["_".$artifact_file_id."_"]= new ArtifactFile($Artifact,$data);
@@ -219,7 +219,7 @@
 			$this->setError('ArtifactFile: Invalid ArtifactFile ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFromID.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFromID.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactFromID.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -41,7 +41,7 @@
 				$this->setError("Invalid Artifact ID");
 				return false;
 			} else {
-				$art_arr =& db_fetch_array($res);
+				$art_arr = db_fetch_array($res);
 			}
 		} 
 

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactHistory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactHistory.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactHistory.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -130,7 +130,7 @@
 			$this->setError('ArtifactHistory: Invalid ArtifactHistory ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactMessage.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactMessage.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactMessage.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -147,7 +147,7 @@
 			$this->setError('ArtifactMessage: Invalid ArtifactMessage ID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactQuery.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactQuery.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactQuery.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -161,7 +161,7 @@
 			$this->setError('ArtifactQuery: Invalid ArtifactQuery ID'.db_error());
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 			$res = db_query_params ('SELECT * FROM artifact_query_fields WHERE artifact_query_id=$1',
 						array ($id)) ;

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactType.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactType.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/ArtifactType.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -45,7 +45,7 @@
 			if (!$res || db_numrows($res) < 1 ){
 				$ARTIFACTTYPE_OBJ["_".$artType_id."_"]=false;
 			} else {
-				$data =& db_fetch_array($res);
+				$data = db_fetch_array($res);
 				$Group =& group_get_object($data["group_id"]);
 				$ARTIFACTTYPE_OBJ["_".$artType_id."_"]= new ArtifactType($Group,$data["group_artifact_id"],$data);
 			}
@@ -291,7 +291,7 @@
 			$this->setError('ArtifactType: Invalid ArtifactTypeID');
 			return false;
 		}
-		$this->data_array =& db_fetch_array($res);
+		$this->data_array = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}
@@ -685,7 +685,7 @@
 			//
 			$resel = db_query_params ('SELECT * FROM artifact_extra_field_elements WHERE extra_field_id=$1',
 						  array ($ef['extra_field_id'])) ;
-			while ($el =& db_fetch_array($resel)) {
+			while ($el = db_fetch_array($resel)) {
 				//new element
 				$nel = new ArtifactExtraFieldElement($nef);
 				if (!$nel->create( addslashes(util_unconvert_htmlspecialchars($el['element_name'])), $el['status_id'] )) {
@@ -732,7 +732,7 @@
 				ORDER BY element_id ASC',
 						 array ($id)) ;
 			$i=0;
-			while($arr =& db_fetch_array($res)) {
+			while($arr = db_fetch_array($res)) {
 				$this->extra_field[$id][$i++] = $arr;
 			}
 //			if (count($this->extra_field[$id]) == 0) {

Modified: trunk/gforge_base/evolvisforge/gforge/cronjobs/massmail.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/cronjobs/massmail.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/cronjobs/massmail.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -133,7 +133,7 @@
 
 // Actual mailing loop
 $compt = 0;
-while ($row =& db_fetch_array($users_res)) {
+while ($row = db_fetch_array($users_res)) {
 	$compt++;
 	if ($type=='SITE' || $type=='COMMNTY') {
 		$tail = "\r\n==================================================================\r\n" ;

Modified: trunk/gforge_base/evolvisforge/gforge/debian/changelog
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/debian/changelog	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/debian/changelog	2010-07-27 15:26:31 UTC (rev 6828)
@@ -8,14 +8,14 @@
   * Unbreak $wgLogo in gforge-plugin-mediawiki
   * Tweak extra development error handler
   * Validate pages with xmlstarlet and the DTD during development
-    and begin fixing related bugs
+    and begin fixing related bugs (XHTML and PHP)
   * Replace $sys_install_type by fine-grained local.d/24debug
   * Build script: can now produce snapshot packages
   * Run error handler/HTML validator only when “on the web”
   * Correct encoding in “project needs approval” mails
   * Unbreak PHP include path
 
- -- Thorsten Glaser <t.glaser at tarent.de>  Tue, 27 Jul 2010 15:07:30 +0200
+ -- Thorsten Glaser <t.glaser at tarent.de>  Tue, 27 Jul 2010 16:01:03 +0200
 
 gforge (4.8.3+evolvis21) unstable; urgency=low
 

Modified: trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/svn-stats.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/svn-stats.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/svn-stats.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -267,7 +267,7 @@
 		return 1;
 	}
 
-	while ($groups =& db_fetch_array($res)) {
+	while ($groups = db_fetch_array($res)) {
 		$logfile = tempnam("/tmp", "svnlog");
 		debug('Working on group ' . $groups[1]);
 
@@ -427,7 +427,7 @@
 		$err .=  "Error! Database Query Failed: ".db_error();
 		return NULL;
 	}
-	if ($row =& db_fetch_array($res)) {
+	if ($row = db_fetch_array($res)) {
 		return $row[0];
 	}
 

Modified: trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/update_users.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/update_users.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/plugins/scmsvn/cronjobs/update_users.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -50,7 +50,7 @@
 // The content of the access file used by svn authz apache2 module
 $access_file_content = '';
 
-while ( $group_row =& db_fetch_array($res) ) {	
+while ( $group_row = db_fetch_array($res) ) {	
 	$access_file_content .= add2AccessFile($group_row['group_id']);
 	if ($per_group_access) {
 		writeAccessFile(sprintf($access_file, $group_row['unix_group_name']), $access_file_content);
@@ -66,7 +66,7 @@
 		}
 
 		$password_file_content = '';
-		while ( $user_row =& db_fetch_array($res) ) {
+		while ( $user_row = db_fetch_array($res) ) {
 			if (!empty($user_row['unix_pw']))
 				$password_file_content .= $user_row['user_name'].':'.$user_row['unix_pw']."\n";
 		}
@@ -86,7 +86,7 @@
 		exit;
 	}
 
-	while ( $row =& db_fetch_array($res) ) {
+	while ( $row = db_fetch_array($res) ) {
 		if (!empty($row["unix_pw"]))
 			$password_file_contents .= $row["user_name"].":".$row["unix_pw"]."\n";
 	}

Modified: trunk/gforge_base/evolvisforge/gforge/plugins/wiki/common/WikiPlugin.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/plugins/wiki/common/WikiPlugin.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/plugins/wiki/common/WikiPlugin.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -210,7 +210,7 @@
 					$wres=db_query($sql);
 
 					$cache = array();
-					while ($arr =& db_fetch_array($wres)) {
+					while ($arr = db_fetch_array($wres)) {
 						$group_name = $group->getUnixName();
 						$data = unserialize($arr['versiondata']);
 						if (!isset($cache[$data['author']])) {

Modified: trunk/gforge_base/evolvisforge/gforge/www/activity/index.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/activity/index.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/activity/index.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -112,7 +112,7 @@
 echo db_error();
 
 $results = array();
-while ($arr =& db_fetch_array($res)) {
+while ($arr = db_fetch_array($res)) {
 	$results[] = $arr;
 }
 

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/add_task.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/add_task.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/add_task.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -39,7 +39,7 @@
 		echo util_make_link ('/pm/admin/?group_id='.$group_id.'&amp;add_cat=1&amp;group_project_id='.$group_project_id,'('._('admin').')');
 		?>
 		</td>
-
+		<td>
 		
 		<input type="submit" value="<?php echo _('Submit') ?>" name="submit" />
 		</td>
@@ -66,7 +66,7 @@
 	<tr>
 		<td colspan="2">
 		<strong><?php echo _('Task Details') ?>:</strong><?php echo notepad_button('document.forms[1].details') ?> <?php echo utils_requiredField(); ?><br />
-		<textarea name="details" rows="5" cols="40" wrap="soft"></textarea></td>
+		<textarea name="details" rows="5" cols="40"></textarea></td>
 	</tr>
 
 	<tr>
@@ -126,8 +126,6 @@
 		<input type="submit" value="<?php echo _('Submit') ?>" name="submit" />
 		</td>
 	</tr>
-	<input type="hidden" name="duration" value="0">
-	<input type="hidden" name="parent_id" value="0">
 <!--
 will add duration and parent_id choices at some point
 	<tr>
@@ -142,6 +140,8 @@
 	</tr>
 -->
 </table>
+<input type="hidden" name="duration" value="0" />
+<input type="hidden" name="parent_id" value="0" />
 </form>
 <?php
 

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/browse_task.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/browse_task.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/browse_task.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -170,7 +170,7 @@
 		} else {
 			$subprojects_box .= '<option ';
 			if($group_project_id == $pg_arr[$j]->getID())
-				$subprojects_box .= ' selected ';
+				$subprojects_box .= ' selected="selected" ';
 			$subprojects_box .= 'value="'. util_make_url ('/pm/task.php?group_project_id='. $pg_arr[$j]->getID().'&amp;group_id='.$group_id.'&amp;func=browse')  .'"  >'. $pg_arr[$j]->getName();
 
 			$subprojects_box .= '</option>';
@@ -261,7 +261,7 @@
 $subProjectName = pm_ispref("subprjname");
 
 echo '
-	<script type="text/javascript">
+	<script language="JavaScript" type="text/javascript">/* <![CDATA[ */
 	function gup(name) {
 		name = name.replace(/[\[]/,"\\\[").replace(/[\]]/,"\\\]");
 		var regexS = "[\\?&]"+name+"=([^&#]*)";
@@ -277,11 +277,11 @@
 		if(url != "All") {
 			top.location.href = url;
 		} else
-			top.location.href = "/pm/task.php?group_id='.$group_id.'&group_project_id='.$group_project_id.'&func=browse&showAll=showAllSubProjects";
+			top.location.href = "/pm/task.php?group_id='.$group_id.'&amp;group_project_id='.$group_project_id.'&func=browse&showAll=showAllSubProjects";
 	}
 
 	function openWinSelectColumns() {
-		url = "/pm/task.php?group_id='.$group_id.'&group_project_id='.$group_project_id.'&func=browse";
+		url = "/pm/task.php?group_id='.$group_id.'&amp;group_project_id='.$group_project_id.'&func=browse";
 		if(gup("showAll"))
 			url += "&showAll="+gup("showAll");
 		top.location.href = url;
@@ -289,7 +289,7 @@
 		selectColumnsWindow.focus();
 
 	}
-	</script>';
+	/* ]]> */</script>';
 
 
 /*
@@ -298,7 +298,7 @@
 echo ' <form name="headerForm" action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&amp;group_project_id='.$group_project_id.'" method="post">
 	<input type="hidden" name="set" value="custom" />
 	<input type="hidden" name="_col_status" value="" />
-	<input type="hidden" name="showAll" value="'. $showAll  .'">
+	<input type="hidden" name="showAll" value="'. $showAll  .'" />
 	<table width="10%" border="0">
 	<tr>
 		<td>'._('Subprojects').'<br />'.$subprojects_box.'</td>
@@ -324,7 +324,7 @@
 	</form>
 	<p />
 
-	<script type="text/javascript">
+	<script language="JavaScript" type="text/javascript">/* <![CDATA[ */
 
 		document.headerForm._assigned_to.onchange = submitForm;
 		document.headerForm._status.onchange = submitForm;
@@ -350,9 +350,7 @@
 		function submitForm() {
 			document.headerForm.submit.click();
 		}
-
-	</script>
-
+	/* ]]> */</script>
  ';
 
 $rows=count($pt_arr);
@@ -377,9 +375,9 @@
 
 	if ($IS_ADMIN) {
 		echo '
-		<form name="taskList" action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&group_project_id='.$pg->getID().'" METHOD="POST">
-		<input type="hidden" name="func" value="massupdate">
-		<input type="hidden" name="showAll" value="'. $showAll  .'">
+		<form name="taskList" action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&amp;group_project_id='.$pg->getID().'" method="post">
+		<input type="hidden" name="func" value="massupdate" />
+		<input type="hidden" name="showAll" value="'. $showAll  .'" />
 	';
 	}
 
@@ -479,16 +477,26 @@
 		echo '
 			<tr class=" '. (($pt_arr[$i]->getStatusId() == 7)?  ' copyAndClosed ' : ' priority'.$pt_arr[$i]->getPriority()) .'">'.
 			'<td>'.
-			($IS_ADMIN?'<input type="CHECKBOX" '. (($pt_arr[$i]->getStatusId() == 7)? 'DISABLED onclick="return false;"':' ') .'   name="project_group_id_list[]" style="display:none;"  value="'. $task_group_project_id .'"> ':'').
-			($IS_ADMIN?'<input type="CHECKBOX" '. (($pt_arr[$i]->getStatusId() == 7)? ' DISABLED onclick="return false;"':' ') .'   name="project_task_id_list[]"   value="'. $pt_arr[$i]->getID() .'"> ':'').
+			($IS_ADMIN?'<input type="checkbox" '. (($pt_arr[$i]->getStatusId() == 7)? 'DISABLED onclick="return false;"':' ') .'   name="project_group_id_list[]" style="display:none;"  value="'. $task_group_project_id .'" /> ':'').
+			($IS_ADMIN?'<input type="checkbox" '. (($pt_arr[$i]->getStatusId() == 7)? ' DISABLED onclick="return false;"':' ') .'   name="project_task_id_list[]"   value="'. $pt_arr[$i]->getID() .'" /> ':'').
 			$pt_arr[$i]->getID() .'</td>';
 		if ($display_col['summary'])
 			echo '<td><a href="'.$url.'">'.$pt_arr[$i]->getSummary() .'</a></td>';
 		if ($display_col['start_date'])
 			echo '<td>'.date(_('Y-m-d H:i'), $pt_arr[$i]->getStartDate() ).'</td>';
-		if ($display_col['end_date'])
-			echo '<td>'. (($now>$pt_arr[$i]->getEndDate() && $pt_arr[$i]->getStatusId() != 2 )?'<strong>* ':'&nbsp; ') .
-				date(_('Y-m-d H:i'), $pt_arr[$i]->getEndDate() ).'</strong></td>';
+		if ($display_col['end_date']) {
+			if ($now>$pt_arr[$i]->getEndDate() && $pt_arr[$i]->getStatusId() != 2) {
+				echo "<td><strong>* ";
+				$x = true;
+			} else {
+				echo "<td>&nbsp; ";
+				$x = false;
+			}
+			echo date(_('Y-m-d H:i'), $pt_arr[$i]->getEndDate());
+			if ($x)
+				echo '</strong>';
+			echo '</td>';
+		}
 		if ($display_col['percent_complete'])
 			echo '<td>'. $pt_arr[$i]->getPercentComplete() .'%</td>';
 		if ($display_col['category'])
@@ -544,13 +552,13 @@
 			echo '
 				<tr class="priority'.$pt_arr[$i]->getPriority() .'">'.
 				'<td>'.
-				($IS_ADMIN?'<input type="CHECKBOX" name="project_task_id_list[]" value="'.
-				$pt_arr[$i]->getID() .'"> ':'').
+				($IS_ADMIN?'<input type="checkbox" name="project_task_id_list[]" value="'.
+				$pt_arr[$i]->getID() .'" /> ':'').
 				$pt_arr[$i]->getID() .'</td>'.
 				'<td><a href="'.$url.'">'.$pt_arr[$i]->getSummary() .'</a></td>'.
 				'<td>'.date(_('Y-m-d H:i'), $pt_arr[$i]->getStartDate() ).'</td>'.
 				'<td>'. (($now>$pt_arr[$i]->getEndDate() )?'<strong>* ':'&nbsp; ') .
-					date(_('Y-m-d H:i'), $pt_arr[$i]->getEndDate() ).'</strong></td>'.
+					date(_('Y-m-d H:i'), $pt_arr[$i]->getEndDate() ).(($now>$pt_arr[$i]->getEndDate())'</strong>':"").'</td>'.
 				'<td>'. $pt_arr[$i]->getPercentComplete() .'%</td></tr>';
 				echo '
 				<tr>'.
@@ -596,20 +604,19 @@
 		}
 		*/
 	}
-	echo '</tbody>';
 	/*
 		Show extra rows for <-- Prev / Next -->
 	*/
 	echo '<tr><td colspan="2">';
 	if ($offset > 0) {
-		echo util_make_link ('/pm/task.php?func=browse&amp;group_project_id='.$group_project_id.'&amp;group_id='.$group_id.'&amp;offset='.($offset-50),'<strong>'._('previous 50').'<--</strong>');
+		echo util_make_link ('/pm/task.php?func=browse&amp;group_project_id='.$group_project_id.'&amp;group_id='.$group_id.'&amp;offset='.($offset-50),'<strong>'._('previous 50').' ← </strong>');
 	} else {
 		echo '&nbsp;';
 	}
 	echo '</td><td>&nbsp;</td><td colspan="2">';
 
 	if ($rows==50) {
-		echo util_make_link ('/pm/task.php?func=browse&amp;group_project_id='.$group_project_id.'&amp;group_id='.$group_id.'&amp;offset='.($offset+50),'<strong>'._('next 50').' --></strong></a>');
+		echo util_make_link ('/pm/task.php?func=browse&amp;group_project_id='.$group_project_id.'&amp;group_id='.$group_id.'&amp;offset='.($offset+50),'<strong>'._('next 50').' → </strong></a>');
 	} else {
 		echo '&nbsp;';
 	}
@@ -632,8 +639,7 @@
 		$tech_box=html_build_select_box_from_arrays ($tech_id_arr,$tech_name_arr,'assigned_to',
 		'100',true,_('No Change'));
 
-		echo '<script language="JavaScript">
-	<!--
+		echo '<script language="JavaScript" type="text/javascript">/* <![CDATA[ */
 	function checkAll(val) {
 		al=document.taskList;
 		len = al.elements.length;
@@ -644,8 +650,7 @@
 			}
 		}
 	}
-	//-->
-	</script>
+	/* ]]> */</script>
 
 			<table width="100%" border="0">
 			<tr><td colspan="2">
@@ -654,8 +659,7 @@
 -
    <a href="javascript:checkAll(0)">'._('Clear &nbsp;all').'</a>
 
-<p>
-<span class="important">'._('<strong>Admin:</strong> If you wish to apply changes to all items selected above, use these controls to change their properties and click once on "Mass Update".').'
+<div class="important">'._('<strong>Admin:</strong> If you wish to apply changes to all items selected above, use these controls to change their properties and click once on "Mass Update".').'</div>
 			</td></tr>
 
 			<tr>
@@ -677,12 +681,12 @@
 
 			<tr><td><strong>'._('Subproject').'</strong><br />
 			'.$pg->groupProjectBox('new_group_project_id',$group_project_id,true,_('No Change')).'</td>
-			<td align="middle"><input type="submit" name="submit" onclick="beforeSubmit();" value="'.
-			_('Mass update').'"></td></tr>
+			<td><input type="submit" name="submit" onclick="beforeSubmit();" value="'.
+			_('Mass update').'" /></td></tr>
 
 			</table>
 		</form>
-	<script type="text/javascript">
+		<script language="JavaScript" type="text/javascript">/* <![CDATA[ */
 
 		if (gup("showAll") == "showAllSubProjects" || document.taskList.showAll.value == "showAllSubProjects") {
 			document.taskList.new_group_project_id.selectedIndex= 0;
@@ -721,7 +725,7 @@
 			}
 			return returnValue;
 		}
-	</script>';
+	/* ]]> */</script>';
 	}
 
 	echo '<p />'._('* Denotes overdue tasks');

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectGroupHTML.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectGroupHTML.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectGroupHTML.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -112,7 +112,7 @@
 	function percentCompleteBox($name='percent_complete',$selected=0) {
 		$status_select = 'status_id';
                 echo '
-                        <select name="'.$name.'" ONCHANGE="switch(this.selectedIndex){
+                        <select name="'.$name.'" onchange="switch(this.selectedIndex){
                                                         case 0: '.$status_select.'.selectedIndex = 0; break;
                                                         case 20: '.$status_select.'.selectedIndex = 5; break;
                                                         default: '.$status_select.'.selectedIndex = 4;

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -27,7 +27,7 @@
 	function multipleDependBox ($name='dependent_on[]') {
 		$result=$this->getOtherTasks();
 		//get the data so we can mark items as SELECTED
-		$arr2 =& array_keys($this->getDependentOn());
+		$arr2 = array_keys($this->getDependentOn());
 		return html_build_multiple_select_box ($result,$name,$arr2);
 	}
 
@@ -60,7 +60,7 @@
 				echo '
 				<tr '. $GLOBALS['HTML']->boxGetAltRowStyle($i) .'>
 					<td>'
-					.util_make_link ('/pm/task.php?func=detailtask&project_task_id='. db_result($result, $i, 'project_task_id'). '&group_id='. $this->ProjectGroup->Group->getID() . '&group_project_id='. $this->ProjectGroup->getID(), db_result($result, $i, 'project_task_id')).'</td>
+					.util_make_link ('/pm/task.php?func=detailtask&project_task_id='. db_result($result, $i, 'project_task_id'). '&amp;group_id='. $this->ProjectGroup->Group->getID() . '&amp;group_project_id='. $this->ProjectGroup->getID(), db_result($result, $i, 'project_task_id')).'</td>
 					<td>'.db_result($result, $i, 'summary').'</td></tr>';
 			}
 
@@ -98,7 +98,7 @@
 			for ($i=0; $i < $rows; $i++) {
 				echo '
 				<tr '. $GLOBALS['HTML']->boxGetAltRowStyle($i) .'>
-					<td>'.util_make_link ('/tracker/?func=detail&aid='.db_result($res,$i,'artifact_id').'&group_id='.db_result($res,$i,'group_id').'&atid='.db_result($res,$i,'group_artifact_id'), db_result($res,$i,'summary')).'</td>
+					<td>'.util_make_link ('/tracker/?func=detail&aid='.db_result($res,$i,'artifact_id').'&amp;group_id='.db_result($res,$i,'group_id').'&atid='.db_result($res,$i,'group_artifact_id'), db_result($res,$i,'summary')).'</td>
 					<td>'. db_result($res,$i,'name') .'</td>
 					<td>'. date(_('Y-m-d H:i'),db_result($res,$i,'open_date')) .'</td>'.
 					(($is_admin) ? '<td><input type="checkbox" name="rem_artifact_id[]" value="'.db_result($res,$i,'artifact_id').'"></td>' : '').

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/include/pm_columns.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/include/pm_columns.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/include/pm_columns.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -52,7 +52,7 @@
 function pm_ispref($name) {
 	global $u;
 
-	return util_ifsetor($u->getPreference("pmdisplay:" . $name));
+	return $u->getPreference("pmdisplay:" . $name);
 }
 
 function pm_prefset($name, $on) {

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/mod_task.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/mod_task.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/mod_task.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -282,7 +282,7 @@
 		<td colspan="3" style="text-align:center">
 			<strong><?php echo _('Copy to another Subproject'); ?>:</strong><br />
 			<?php echo $pg->groupProjectBox('copy_group_project_id',$group_project_id,false); ?> 
-			<?php echo '<input type="submit" name="CopySubproject" value="'._('Copy').'" onclick="document.forms[0].func.value = \'copytask\';" '; ?> 
+			<?php echo '<input type="submit" name="CopySubproject" value="'._('Copy').'" onclick="document.forms[0].func.value = \'copytask\';" />'; ?> 
 		</td>
 	</tr>
         

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/t_follow.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/t_follow.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/t_follow.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -54,9 +54,9 @@
 	exit;
 }
 
-$dsturl = util_make_url("/pm/task.php?func=detailtask&project_task_id=" .
-    $tinfo['project_task_id'] . "&group_id=" . $tinfo['group_id'] .
-    "&group_project_id=" . $tinfo['group_project_id']);
+$dsturl = util_make_url("/pm/task.php?func=detailtask&amp;project_task_id=" .
+    $tinfo['project_task_id'] . "&amp;group_id=" . $tinfo['group_id'] .
+    "&amp;group_project_id=" . $tinfo['group_project_id']);
 header("HTTP/1.0 302 Found");
 header("Location: " . $dsturl);
 echo "The result is at:\n" . $dsturl . "\n";

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/add.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/add.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/add.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -31,10 +31,10 @@
 	echo notepad_func();
 	echo $ath->getSubmitInstructions();
 
-	echo '<p>
+	echo '
 
 	<form action="'.getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID().'" method="post" enctype="multipart/form-data">
-	<input type="hidden" name="form_key" value="'.form_generate_key().'">
+	<input type="hidden" name="form_key" value="'.form_generate_key().'" />
 	<input type="hidden" name="func" value="postadd" />
 	<table>';
 	echo '
@@ -70,7 +70,7 @@
 	
 	?>
 	<tr>
-		<td colspan="2"><strong><?php echo _('Summary') ?>: <a href="javascript:help_window('<?php echo util_make_url ('/help/tracker.php?helpname=summary'); ?>')"></strong><?php echo utils_requiredField(); ?><strong>(?)</strong></a><br />
+		<td colspan="2"><strong><?php echo _('Summary') ?>: <a href="javascript:help_window('<?php echo util_make_url ('/help/tracker.php?helpname=summary'); ?>')"></a><?php echo utils_requiredField(); ?><strong>(?)</strong></strong><br />
 		<input type="text" name="summary" size="80" maxlength="255" />
 		</td>
 	</tr>
@@ -110,15 +110,16 @@
 		<input type="file" name="input_file[]" size="30" /><br />
 		<input type="file" name="input_file[]" size="30" /><br />
 		<input type="file" name="input_file[]" size="30" /><br />
+		</p>
 		</td>
-	<tr>
+	</tr>
 
 	<tr><td colspan="2">
 		<input type="submit" name="submit" value="<?php echo _('Submit')?>" />
 		</td>
 	</tr>
 
-	</table></form></p>
+	</table></form>
 
 	<?php
 

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addcanned.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addcanned.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addcanned.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -41,13 +41,13 @@
 		?>
 		<p><?php echo _('Creating useful generic messages can save you a lot of time when handling common artifact requests.') ?></p>
 		<p>
-		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<input type="hidden" name="add_canned" value="y" />
 		<strong><?php echo _('Title') ?>:</strong><br />
 		<input type="text" name="title" value="" size="50" maxlength="50" />
 		<p>
 		<strong><?php echo _('Message Body') ?>:</strong><br />
-		<textarea name="body" rows="30" cols="65" wrap="hard"></textarea></p>
+		<textarea name="body" rows="30" cols="65"></textarea></p>
 		<p>
 		<input type="submit" name="post_changes" value="<?php echo _('Submit') ?>" /></p>
 		</form>

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafield.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafield.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafield.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -11,7 +11,7 @@
 		/*
 			List of possible user built Selection Boxes for an ArtifactType
 		*/
-		$efarr =& $ath->getExtraFields();
+		$efarr = $ath->getExtraFields();
 		$eftypes=ArtifactExtraField::getAvailableTypes();
 		$keys=array_keys($efarr);
 		echo "<br />";
@@ -82,7 +82,7 @@
 		echo "<h2>"._('Add New Custom Field')."</h2>";
 		?>
 		<p>
-		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<input type="hidden" name="add_extrafield" value="y" />
 		<strong><?php echo _('Custom Field Name') ?>:</strong><br />
 		<input type="text" name="name" value="" size="15" maxlength="30" /><br />

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafieldoption.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafieldoption.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-addextrafieldoption.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -10,7 +10,7 @@
 	} elseif ($ac->isError()) {
 		exit_error('Error',$ac->getErrorMessage());
 	} else {
-	  	$efearr=$ath->getExtraFieldElements($boxid);
+	  	$efearr = $ath->getExtraFieldElements($boxid);
 		$title = sprintf(_('Add/Update Custom Field Elements in %s'), $ath->getName());
 		$ath->adminHeader(array ('title'=>$title));
 
@@ -38,7 +38,7 @@
 		}
 		?>
 		<p>
-		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&boxid='.$boxid.'&atid='.$ath->getID(); ?>" method="post">
+		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&boxid='.$boxid.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<input type="hidden" name="add_opt" value="y" />
 		<strong><?php echo _('Add New Element') ?>:</strong><br />
 		<input type="text" name="name" value="" size="15" maxlength="30" /> <br \>

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-clonetracker.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-clonetracker.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-clonetracker.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -31,7 +31,7 @@
 				?>
 				<p><?php echo _('Choose the template tracker to clone. The site administrator will have to set up trackers with default values and set permissions properly so you can access them.') ?></p>
 				<p>
-				<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+				<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 				<input type="hidden" name="clone_tracker" value="y" />
 				<p><strong><?php echo _('WARNING!!! Cloning this tracker will duplicate all the fields and all the elements from those fields into this tracker. There is nothing to prevent you from cloning multiple times or making a huge mess. You have been warned!') ?></strong></p>
 				<p><?php echo html_build_select_box_from_arrays($ids,$titles,'clone_id','',false); ?></p>

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-deleteextrafield.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-deleteextrafield.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-deleteextrafield.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -5,7 +5,7 @@
 		$id = getStringFromRequest('id');
 
 		?>
-		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 		<p>
 		<input type="hidden" name="deleteextrafield" value="y" /><br />
 		<input type="hidden" name="id" value="<?php echo $id; ?>" /><br />

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-extrafieldcopy.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-extrafieldcopy.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-extrafieldcopy.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -9,7 +9,7 @@
 		$ath->adminHeader(array ('title'=>$title));
 		echo "<h3>".$title."</h3>";
 		
-		$efearr =& $ath->getExtraFieldElements($id);
+		$efearr = $ath->getExtraFieldElements($id);
 		for ($i=0; $i<count($efearr); $i++) {
 			$field_id_arr[] = $efearr[$i]['element_id'];
 			$field_arr[] = $efearr[$i]['element_name'];
@@ -28,7 +28,7 @@
 		echo '<td valign=top>';
 		?>
 		
-		<form action="<?php echo getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post" >
+		<form action="<?php echo getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post" >
 		<input type="hidden" name="copy_opt" value="copy" >
 		<input type="hidden" name="id" value="<?php echo $id; ?>">
 		<?php

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatecanned.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatecanned.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatecanned.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -16,14 +16,14 @@
 		} else {
 			?>
 			<p><?php echo _('Creating useful generic messages can save you a lot of time when handling common artifact requests.') ?></p>
-			<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&atid='.$ath->getID(); ?>" method="post">
+			<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&amp;atid='.$ath->getID(); ?>" method="post">
 			<input type="hidden" name="update_canned" value="y" />
 			<input type="hidden" name="id" value="<?php echo $acr->getID(); ?>" />
 			<strong><?php echo _('Title') ?>:</strong><br />
 			<input type="text" name="title" value="<?php echo $acr->getTitle(); ?>" size="50" maxlength="50" />
 			<p>
 			<strong><?php echo _('Message Body') ?>:</strong><br />
-			<textarea name="body" rows="30" cols="65" wrap="hard"><?php echo $acr->getBody(); ?></textarea></p>
+			<textarea name="body" rows="30" cols="65"><?php echo $acr->getBody(); ?></textarea></p>
 			<p>
 			<input type="submit" name="post_changes" value="<?php echo _('Submit') ?>" /></p>
 			</form>

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updateextrafield.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updateextrafield.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updateextrafield.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -21,7 +21,7 @@
 			<p>
 			<strong><?php echo _('Type of custom field').': '.$ac->getTypeName(); ?></strong><br />
 			
-			<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&id='.$id.'&atid='.$ath->getID(); ?>" method="post">
+			<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id.'&id='.$id.'&amp;atid='.$ath->getID(); ?>" method="post">
 			<input type="hidden" name="update_box" value="y" />
 			<input type="hidden" name="id" value="<?php echo $ac->getID(); ?>" />
 			<input type="hidden" name="is_required" value="0" />

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatetracker.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatetracker.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/form-updatetracker.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -42,10 +42,10 @@
 		<input type="text" name="status_timeout"  value="<?php echo($ath->getStatusTimeout() / 86400); ?>" /></p>
 		<p>
 		<strong><?php echo _('Free form text for the "submit new item" page') ?>:</strong><br />
-		<textarea name="submit_instructions" rows="10" cols="55" wrap="hard"><?php echo $ath->getSubmitInstructions(); ?></textarea></p>
+		<textarea name="submit_instructions" rows="10" cols="55"><?php echo $ath->getSubmitInstructions(); ?></textarea></p>
 		<p>
 		<strong><?php echo _('Free form text for the "browse items" page') ?>:</strong><br />
-		<textarea name="browse_instructions" rows="10" cols="55" wrap="hard"><?php echo $ath->getBrowseInstructions(); ?></textarea></p>
+		<textarea name="browse_instructions" rows="10" cols="55"><?php echo $ath->getBrowseInstructions(); ?></textarea></p>
 		<p>
 		<input type="submit" name="post_changes" value="<?php echo _('Submit') ?>" /></p>
 		</form>

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/ind.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/ind.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/admin/ind.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -42,7 +42,7 @@
 				$due_period,$use_resolution,$submit_instructions,$browse_instructions)) {
 				$feedback .= $res->getErrorMessage();
 			} else {
-				header ("Location: ".util_make_url ("/tracker/admin/?group_id=$group_id&atid=".$res->getID()."&update_users=1"));
+				header ("Location: ".util_make_url ("/tracker/admin/?group_id=$group_id&amp;atid=".$res->getID()."&update_users=1"));
 			}
 
 		}
@@ -116,19 +116,18 @@
 		//show nothing
 	} else {
 
-	?><?php echo _('<h3>Create a new tracker</h3><p>You can use this system to track virtually any kind of data, with each tracker having separate user, group, category, and permission lists. You can also easily move items between trackers when needed.</p><p>Trackers are referred to as "Artifact Types" and individual pieces of data are "Artifacts". "Bugs" might be an Artifact Type, whiles a bug report would be an Artifact. You can create as many Artifact Types as you want, but remember you need to set up categories, groups, and permission for each type, which can get time-consuming') ?>
-	<p>
+	?><?php echo _('<h3>Create a new tracker</h3><p>You can use this system to track virtually any kind of data, with each tracker having separate user, group, category, and permission lists. You can also easily move items between trackers when needed.</p><p>Trackers are referred to as "Artifact Types" and individual pieces of data are "Artifacts". "Bugs" might be an Artifact Type, whiles a bug report would be an Artifact. You can create as many Artifact Types as you want, but remember you need to set up categories, groups, and permission for each type, which can get time-consuming') ?></p>
 	<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id; ?>" method="post">
 	<input type="hidden" name="add_at" value="y" />
 	<p>
 	<?php echo _('<strong> Name:</strong> (examples: meeting minutes, test results, RFP Docs)') ?><br />
-	<input type="text" name="name" value=""></p>
+	<input type="text" name="name" value="" /></p>
 	<p>
 	<strong><?php echo _('Description') ?>:</strong><br />
 	<input type="text" name="description" value="" size="50" /></p>
 	<p>
 	<input type="checkbox" name="is_public" value="1" /> <strong><?php echo _('Publicly Available') ?></strong><br />
-	<input type="checkbox" name="allow_anon" value="1" /> <strong><?php echo _('Allow non-logged-in postings') ?></strong><br />
+	<input type="checkbox" name="allow_anon" value="1" /> <strong><?php echo _('Allow non-logged-in postings') ?></strong><br /></p>
 	<p>
 	<strong><?php echo _('Send email on new submission to address') ?>:</strong><br />
 	<input type="text" name="email_address" value="" /></p>
@@ -142,13 +141,13 @@
 	<input type="text" name="status_timeout" value="14" /></p>
 	<p>
 	<strong><?php echo _('Free form text for the "submit new item" page') ?>:</strong><br />
-	<textarea name="submit_instructions" rows="10" cols="55" wrap="hard"></textarea></p>
+	<textarea name="submit_instructions" rows="10" cols="55"></textarea></p>
 	<p>
 	<strong><?php echo _('Free form text for the "browse items" page') ?>:</strong><br />
-	<textarea name="browse_instructions" rows="10" cols="55" wrap="hard"></textarea></p>
+	<textarea name="browse_instructions" rows="10" cols="55"></textarea></p>
 	<p>
 	<input type="submit" name="post_changes" value="<?php echo _('Submit') ?>" /></p>
-	</form></p>
+	</form>
 	<?php
 	}
 

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/browse.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/browse.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/browse.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -221,34 +221,34 @@
 */
 if (session_loggedin()) {
 	echo '<td rowspan="2">';
-	echo '<form action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&atid='.$ath->getID().'" method="post">';
-	echo '<input type="hidden" name="power_query" value="1">';
+	echo '<form action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&amp;atid='.$ath->getID().'" method="post">';
+	echo '<input type="hidden" name="power_query" value="1" />';
 	$res=db_query("SELECT artifact_query_id,query_name 
 	FROM artifact_query WHERE user_id='".user_getid()."' AND group_artifact_id='".$ath->getID()."'");
 
 	if (db_numrows($res)>0) {
 	echo 
 		html_build_select_box($res,'query_id',$af->getDefaultQuery(),false).'<br />
-		<input type="submit" name="run" value="'._('Power Query').'"></input>
-		<strong><a href="javascript:admin_window(\''.util_make_url ('/tracker/?func=query&group_id='.$group_id.'&atid='.$ath->getID()).'\')">'.
+		<input type="submit" name="run" value="'._('Power Query').'" />
+		<strong><a href="javascript:admin_window(\''.util_make_url ('/tracker/?func=query&amp;group_id='.$group_id.'&amp;atid='.$ath->getID()).'\')">'.
 		_('Build Query').'</a></strong>';
 	} else {
 		echo '<strong>
-		<a href="javascript:admin_window(\''.util_make_url ('/tracker/?func=query&group_id='.$group_id.'&atid='.$ath->getID()).'\')">'._('Build Query').'</a></strong>';
+		<a href="javascript:admin_window(\''.util_make_url ('/tracker/?func=query&amp;group_id='.$group_id.'&amp;atid='.$ath->getID()).'\')">'._('Build Query').'</a></strong>';
 	}
 	echo '
 		</form>
 		</td>';
 }
 echo '
-	<form action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&atid='.$ath->getID().'" method="post">
+	<form action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&amp;atid='.$ath->getID().'" method="post">
 	<input type="hidden" name="set" value="custom" />
 	<td>'._('Assignee').'<br />'. $tech_box .'</td>'.
 	'<td>'._('Status').'<br />'. $status_box .'</td>';
 	echo '
 </tr>
 
-<input type="hidden" name="query_id" value="-1">';
+<input type="hidden" name="query_id" value="-1" />';
 
 	echo '
 	<tr>
@@ -283,9 +283,9 @@
 
 	if ($IS_ADMIN) {
 		echo '
-		<form name="artifactList" action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&atid='.$ath->getID().'" METHOD="POST">
-		<input type="hidden" name="form_key" value="'.form_generate_key().'">
-		<input type="hidden" name="func" value="massupdate">';
+		<form name="artifactList" action="'. getStringFromServer('PHP_SELF') .'?group_id='.$group_id.'&amp;atid='.$ath->getID().'" METHOD="POST">
+		<input type="hidden" name="form_key" value="'.form_generate_key().'" />
+		<input type="hidden" name="func" value="massupdate" />';
 	}
 
 	$display_col=array('summary'=>1,
@@ -327,7 +327,7 @@
 		<tr '. $HTML->boxGetAltRowStyle($i) . '>'.
 		'<td>'.
 		($IS_ADMIN?'<input type="CHECKBOX" name="artifact_id_list[]" value="'.
-			$art_arr[$i]->getID() .'"> ':'').
+			$art_arr[$i]->getID() .'" /> ':'').
 			$art_arr[$i]->getID() .
 			'</td>';
 		if ($display_col['summary'])
@@ -396,7 +396,7 @@
 		if ($j == $currentpage) {
 			echo '<strong>'.($j+1).'</strong>&nbsp;&nbsp;';
 		} else {
-			echo '<a href="'.getStringFromServer('PHP_SELF')."?func=browse&amp;group_id=".$group_id.'&atid='.$ath->getID().'&set='. $set.'&start='.($j*25).'"><strong>'.($j+1).'</strong></a>&nbsp;&nbsp;';
+			echo '<a href="'.getStringFromServer('PHP_SELF')."?func=browse&amp;group_id=".$group_id.'&amp;atid='.$ath->getID().'&set='. $set.'&start='.($j*25).'"><strong>'.($j+1).'</strong></a>&nbsp;&nbsp;';
 		}
 	}
 
@@ -434,7 +434,7 @@
 		//
 		//	build custom fields
 		//
-	$ef =& $ath->getExtraFields(ARTIFACT_EXTRAFIELD_FILTER_INT);
+	$ef = $ath->getExtraFields(ARTIFACT_EXTRAFIELD_FILTER_INT);
 	$keys=array_keys($ef);
 
 	$sel=array();
@@ -470,7 +470,7 @@
 				<a href="javascript:help_window(\'/help/tracker.php?helpname=canned_response\')"><strong>(?)</strong></a>
 				</strong><br />'. $ath->cannedResponseBox ('canned_response') .'</td></tr>
 
-			<tr><td colspan="3" align="MIDDLE"><input type="SUBMIT" name="submit" value="'._('Mass update').'"></td></tr>
+			<tr><td colspan="3" align="middle"><input type="submit" name="submit" value="'._('Mass update').'" /></td></tr>
 
 			</table>
 		</form>';

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/downloadcsv.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/downloadcsv.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/downloadcsv.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -53,7 +53,7 @@
 //
 //	Show the extra fields
 //
-$ef =& $ath->getExtraFields(ARTIFACT_EXTRAFIELD_FILTER_INT);
+$ef = $ath->getExtraFields(ARTIFACT_EXTRAFIELD_FILTER_INT);
 $keys=array_keys($ef);
 for ($i=0; $i<count($keys); $i++) {
 	echo ',"'.$ef[$keys[$i]]['field_name'].'"';

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -84,7 +84,7 @@
 		$links_arr[]='/tracker/admin/?group_id='.$group_id;
 		$title_arr[]=_('New Tracker');
 
-		$links_arr[]='/tracker/admin/?group_id='.$group_id.'&amp;atid='.$this->getID().'&update_type=1';
+		$links_arr[]='/tracker/admin/?group_id='.$group_id.'&amp;atid='.$this->getID().'&amp;update_type=1';
 		$title_arr[]=_('Update Settings');
 
 		$links_arr[]='/tracker/admin/?group_id='.$group_id.'&amp;atid='.$this->getID().'&amp;add_extrafield=1';
@@ -175,7 +175,7 @@
 	 *	@return	string	HTML template.
 	 */
 	function generateRenderHTML($filter='') {
-		$efarr =& $this->getExtraFields($filter);
+		$efarr = $this->getExtraFields($filter);
 		//each two columns, we'll reset this and start a new row
 
 		$return = '
@@ -278,7 +278,7 @@
 		if ($text_100 == 'none'){
 			$text_100=_('None');
 		}
-		$arr =& $this->getExtraFieldElements($extra_field_id);
+		$arr = $this->getExtraFieldElements($extra_field_id);
 		for ($i=0; $i<count($arr); $i++) {
 			$keys[$i]=$arr[$i]['element_id'];
 			$vals[$i]=$arr[$i]['element_name'];
@@ -296,7 +296,7 @@
 	 *	@return		radio buttons
 	 */	
 	function renderRadio ($extra_field_id,$checked='xzxz',$show_100=false,$text_100='none',$show_any=false,$text_any='Any') {
-		$arr =& $this->getExtraFieldElements($extra_field_id);
+		$arr = $this->getExtraFieldElements($extra_field_id);
 		for ($i=0; $i<count($arr); $i++) {
 			$keys[$i]=$arr[$i]['element_id'];
 			$vals[$i]=$arr[$i]['element_name'];
@@ -320,7 +320,7 @@
 		if (!$checked || !is_array($checked)) {
 			$checked=array();
 		}
-		$arr =& $this->getExtraFieldElements($extra_field_id);
+		$arr = $this->getExtraFieldElements($extra_field_id);
 		if ($show_100) {
 			$return .= '
 				<input type="checkbox" name="extra_fields['.$extra_field_id.'][]" value="100" '.
@@ -344,7 +344,7 @@
 	 *	@return		radio multiselectbox
 	 */	
 	function renderMultiSelectBox ($extra_field_id,$checked=array(),$show_100=false,$text_100='none') {
-		$arr =& $this->getExtraFieldElements($extra_field_id);
+		$arr = $this->getExtraFieldElements($extra_field_id);
 		if (!$checked) {
 			$checked=array();
 		}
@@ -353,7 +353,7 @@
 		}	
 		$keys=array();
 		$vals=array();
-		$arr =& $this->getExtraFieldElements($extra_field_id);
+		$arr = $this->getExtraFieldElements($extra_field_id);
 		for ($i=0; $i<count($arr); $i++) {
 			$keys[]=$arr[$i]['element_id'];
 			$vals[]=$arr[$i]['element_name'];

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/mod.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/mod.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/mod.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -220,6 +220,7 @@
 				</tr>';
 			}
 			echo $GLOBALS['HTML']->listTableBottom();
+			echo "</td></tr>\n";
 		} else {
 			echo '<tr><td colspan="3">'._('No Related Tasks').'</td></tr>';
 		}
@@ -273,6 +274,7 @@
 </div>
 <div class="tabbertab" title="<?php echo _('Commits'); ?>">
 <table border="0" width="80%">
+<tr style="display:none;"><td colspan="2">dummy</td></tr>
 	<?php
 		$hookParams['artifact_id']=$aid;
 		plugin_hook("artifact_extra_detail",$hookParams);

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/query.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/query.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/query.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -141,7 +141,7 @@
 //
 $_assigned_to=$aq->getAssignee();
 $_status=$aq->getStatus();
-$extra_fields =& $aq->getExtraFields();
+$extra_fields = $aq->getExtraFields();
 $_sort_col=$aq->getSortCol();
 $_sort_ord=$aq->getSortOrd();
 $_moddaterange=$aq->getModDateRange();
@@ -232,7 +232,7 @@
 <h1>'. $feedback .'</h1>
 
 <table border="3" cellpadding="4" rules="groups" frame="box" width="100%" class="tablecontent">
-	<form action="'.getStringFromServer('PHP_SELF').'?func=query&group_id='.$group_id.'&atid='.$ath->getID().'" method="post">
+	<form action="'.getStringFromServer('PHP_SELF').'?func=query&amp;group_id='.$group_id.'&amp;atid='.$ath->getID().'" method="post">
 	<input type="hidden" name="form_key" value="'.form_generate_key().'">
 	<tr>
 		<td>

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/reporting/index.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/reporting/index.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/reporting/index.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -114,12 +114,12 @@
 <?php if ($atid) {
 		if (!$area || $area == 'activity') { 
 	?>
-	<img src="trackeract_graph.php?<?php echo "SPAN=$SPAN&start=$start&end=$end&group_id=$group_id&atid=$atid"; ?>" width="640" height="480">
+	<img src="trackeract_graph.php?<?php echo "SPAN=$SPAN&start=$start&end=$end&amp;group_id=$group_id&amp;atid=$atid"; ?>" width="640" height="480">
 	<p>
 	<?php
 		} else {
 	?>
-	<img src="trackerpie_graph.php?<?php echo "SPAN=$SPAN&start=$start&end=$end&group_id=$group_id&atid=$atid&area=$area"; ?>" width="640" height="480">
+	<img src="trackerpie_graph.php?<?php echo "SPAN=$SPAN&start=$start&end=$end&amp;group_id=$group_id&amp;atid=$atid&area=$area"; ?>" width="640" height="480">
 	<p>
 	<?php
 

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/tracker.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/tracker.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/tracker.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -464,7 +464,7 @@
 	}
 	case 'download' : {
 		$aid = getStringFromRequest('aid');
-		Header("Redirect: ".util_make_url ("/tracker/download.php?group_id=$group_id&atid=$atid&aid=$aid&file_id=$file_id"));
+		Header("Redirect: ".util_make_url ("/tracker/download.php?group_id=$group_id&amp;atid=$atid&amp;aid=$aid&file_id=$file_id"));
 		break;
 	}
 	case 'detail' : {

Modified: trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategory.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategory.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -89,7 +89,7 @@
 		if (!$res || db_numrows($res) < 1) {
 			return false;
 		}
-		$this->dataArray =& db_fetch_array($res);
+		$this->dataArray = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}
@@ -161,7 +161,7 @@
 			if (!$res) {
 				return $this->labels;
 			}
-			while($data =& db_fetch_array($res)) {
+			while($data = db_fetch_array($res)) {
 				$this->labels[$data['language_id']] = new TroveCategoryLabel($this, $data['label_id'], $data);
 			}
 			db_free_result($res);

Modified: trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategoryLabel.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategoryLabel.class.php	2010-07-27 15:26:26 UTC (rev 6827)
+++ trunk/gforge_base/evolvisforge/gforge/www/trove/TroveCategoryLabel.class.php	2010-07-27 15:26:31 UTC (rev 6828)
@@ -105,7 +105,7 @@
 		if (!$res || db_numrows($res) < 1) {
 			return false;
 		}
-		$this->dataArray =& db_fetch_array($res);
+		$this->dataArray = db_fetch_array($res);
 		db_free_result($res);
 		return true;
 	}



More information about the evolvis-commits mailing list