[evolvis-commits] r6682: prevent a possible race↵ ↵ add_members just errors out if the list doesn’t exist , which does↵ not matter to us , but if there’s a time window between mailing list↵ creation and quick subscription , and users quick-subscribe within↵ that window , the subscription will fail, which is not what we want, ↵ so just run the two cronjob scripts in immediate succession↵

Thorsten Glaser t.glaser at tarent.de
Wed Jun 2 16:42:55 CEST 2010


Author: Thorsten Glaser <t.glaser at tarent.de>
Date: 2010-06-02 16:42:54 +0200 (Wed, 02 Jun 2010)
New Revision: 6682

Modified:
   trunk/gforge_base/evolvisforge/gforge/cron.d/lists-mailman
Log:
prevent a possible race

add_members just errors out if the list doesn’t exist, which does
not matter to us, but if there’s a time window between mailing list
creation and quick subscription, and users quick-subscribe within
that window, the subscription will fail, which is not what we want,
so just run the two cronjob scripts in immediate succession


Modified: trunk/gforge_base/evolvisforge/gforge/cron.d/lists-mailman
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/cron.d/lists-mailman	2010-06-02 14:42:52 UTC (rev 6681)
+++ trunk/gforge_base/evolvisforge/gforge/cron.d/lists-mailman	2010-06-02 14:42:54 UTC (rev 6682)
@@ -2,8 +2,5 @@
 # Regular cron jobs for the lists-mailman package
 #
 
-# Mailing-list creation
-55 * * * * root [ -x /usr/share/gforge/bin/create-mailing-lists.pl ] && /usr/share/gforge/bin/create-mailing-lists.pl > /dev/null 2>&1
-
-# Quick ML subscription
-5 * * * * root [ -x /usr/share/gforge/cronjobs/mm_quicksubscribe.sh ] && /usr/share/gforge/cronjobs/mm_quicksubscribe.sh >/dev/null 2>&1
+# mailing list creation and quick subscription
+55 * * * * root [ -x /usr/share/gforge/bin/create-mailing-lists.pl ] && /usr/share/gforge/bin/create-mailing-lists.pl >/dev/null 2>&1; [ -x /usr/share/gforge/cronjobs/mm_quicksubscribe.sh ] && /usr/share/gforge/cronjobs/mm_quicksubscribe.sh >/dev/null 2>&1




More information about the evolvis-commits mailing list