[evolvis-commits] r6926: reverse sort order in Tasks and Tracker from antichronologically↵ to chronologically ; requested by many; prodded by ldegen [#681] ↵

mirabilos at evolvis.org mirabilos at evolvis.org
Mon Sep 6 15:52:39 CEST 2010


Author: mirabilos
Date: 2010-09-06 15:52:39 +0200 (Mon, 06 Sep 2010)
New Revision: 6926

Modified:
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php
   trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php
   trunk/gforge_base/evolvisforge/gforge/debian/changelog
   trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactHtml.class.php
Log:
reverse sort order in Tasks and Tracker from antichronologically
to chronologically; requested by many; prodded by ldegen [#681]


Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php	2010-09-06 13:52:38 UTC (rev 6925)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php	2010-09-06 13:52:39 UTC (rev 6926)
@@ -655,11 +655,11 @@
 	 *
 	 *  @return database result set.
 	 */
-	function getMessages() {
+	function getMessages($asc=false) {
 		return db_query_params ('SELECT * 
 		FROM project_message_user_vw 
 		WHERE project_task_id=$1
-		ORDER BY postdate DESC',
+		ORDER BY postdate ' . ($asc ? 'ASC' : 'DESC'),
 					array ($this->getID())) ;
 	}
 

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php	2010-09-06 13:52:38 UTC (rev 6925)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php	2010-09-06 13:52:39 UTC (rev 6926)
@@ -630,8 +630,8 @@
 	 *
 	 *	@return database result set.
 	 */
-	function getMessages() {
-		return db_query_params ('SELECT * FROM artifact_message_user_vw WHERE artifact_id=$1 ORDER BY adddate DESC',
+	function getMessages($asc=false) {
+		return db_query_params ('SELECT * FROM artifact_message_user_vw WHERE artifact_id=$1 ORDER BY adddate ' . ($asc ? 'ASC' : 'DESC'),
 					array ($this->getID())) ;
 	}
 

Modified: trunk/gforge_base/evolvisforge/gforge/debian/changelog
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/debian/changelog	2010-09-06 13:52:38 UTC (rev 6925)
+++ trunk/gforge_base/evolvisforge/gforge/debian/changelog	2010-09-06 13:52:39 UTC (rev 6926)
@@ -21,11 +21,12 @@
   * Silently ignore duplicate tracker-task relationships [#983]
   * Fix $feedback multiline with <br />
   * Rewrite the group admin page to conform to XHTML/1.0
+  * Sort comments in Tasks and Tracker chronologically
 
   [ Alain Peyrat ]
   * Switch default search type from OR to AND
 
- -- Thorsten Glaser <t.glaser at tarent.de>  Mon, 06 Sep 2010 14:41:54 +0200
+ -- Thorsten Glaser <t.glaser at tarent.de>  Mon, 06 Sep 2010 14:51:58 +0200
 
 gforge (4.8.3+evolvis24) unstable; urgency=low
 

Modified: trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php	2010-09-06 13:52:38 UTC (rev 6925)
+++ trunk/gforge_base/evolvisforge/gforge/www/pm/include/ProjectTaskHTML.class.php	2010-09-06 13:52:39 UTC (rev 6926)
@@ -116,7 +116,7 @@
 		/*
 			Show the details rows from task_history
 		*/
-		$result=$this->getMessages();
+		$result=$this->getMessages(true);
 		$rows=db_numrows($result);
 
 		if ($rows > 0) {

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactHtml.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactHtml.class.php	2010-09-06 13:52:38 UTC (rev 6925)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactHtml.class.php	2010-09-06 13:52:39 UTC (rev 6926)
@@ -44,7 +44,7 @@
 
 
 	function showMessages() {
-		$result= $this->getMessages();
+		$result= $this->getMessages(true);
 		$rows=db_numrows($result);
 
 		if ($rows > 0) {



More information about the evolvis-commits mailing list