[evolvis-commits] r8798: RFE [ #359 ] Make the 'most forum posts' stats work again↵

mirabilos at evolvis.org mirabilos at evolvis.org
Thu Feb 24 16:52:56 CET 2011


Author: mirabilos
Date: 2011-02-24 16:52:56 +0100 (Thu, 24 Feb 2011)
New Revision: 8798

Modified:
   trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog
   trunk/gforge_base/evolvisforge-5.1/gforge/www/top/index.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/top/toplist.php
Log:
RFE [ #359 ] Make the 'most forum posts' stats work again


Modified: trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog	2011-02-24 15:52:55 UTC (rev 8797)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog	2011-02-24 15:52:56 UTC (rev 8798)
@@ -4,6 +4,9 @@
 	common/pm/ProjectTasksForUser.class, common/tracker/ArtifactsForUser.class
 	Applied patch #349: Refactoring of the www/my/index.php page. Thanks to
 	Jeff Fynboh for the code.
+	
+	* www/top/toplist.php,index.php:
+	Made the "Top forum posts" work again.
 
 2003-05-19 Tom Copeland <tom at infoether.com>
 

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/top/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/top/index.php	2011-02-24 15:52:55 UTC (rev 8797)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/top/index.php	2011-02-24 15:52:56 UTC (rev 8798)
@@ -35,10 +35,10 @@
 Measured by impressions of the <?php echo $GLOBALS['sys_name']?> 'button' logo
 <li><a href="toplist.php?type=pageviews_proj"><?php echo $Language->getText('top','pageviews',$GLOBALS['sys_name']); ?></a> 
 <br /> 
-<li><a href="toplist.php?type=forumposts_week"><?php echo $Language->getText('top','forum_posts'); ?></a>
 <br /> 
 <li><a href="topusers.php"><?php echo $Language->getText('top','highest_ranked_users'); ?></a>
 -->
+<li><a href="toplist.php?type=forumposts_week"><?php echo $Language->getText('top','forum_posts'); ?></a>
 </ul>
 
 <?php

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/top/toplist.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/top/toplist.php	2011-02-24 15:52:55 UTC (rev 8797)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/top/toplist.php	2011-02-24 15:52:56 UTC (rev 8798)
@@ -19,7 +19,7 @@
 	$column1 = $Language->getText('top_toplist','pageviews');
 }
 else if ($GLOBALS[type] == 'forumposts_week') {
-	$rankfield = 'forumposts_week';
+	$rankfield = 'msg_posted';
 	$title = $Language->getText('top_toplist','top_forum_post_count');
 	$column1 = $Language->getText('top_toplist','posts');
 }
@@ -33,50 +33,33 @@
 
 $HTML->header(array('title'=>$title));
 
-print '<p><strong><FONT size="+1">'.$title.'</FONT></strong>
-<br /><em>('.$Language->getText('top','updated_daily').')</em>
+print '<p><a href="/top/">['.$Language->getText('top','view_other_top_category').']</a>';
 
-<p><a href="/top/">['.$Language->getText('top','view_other_top_category').']</a>';
+$arr=array($Language->getText('top_toplist','rank'),$Language->getText('top_toplist','project_name'),"$column1");
 
-$arr=array($Language->getText('top_toplist','rank'),$Language->getText('top_toplist','project_name'),"$column1",$Language->getText('top_toplist','last_rank'),
-					$Language->getText('top_toplist','change'));
-
 echo $HTML->listTableTop($arr);
 
-$res_top = db_query("SELECT groups.group_id,groups.group_name,groups.unix_group_name,top_group.$rankfield,".
-	"top_group.rank_$rankfield,top_group.rank_".$rankfield."_old ".
-	"FROM groups,top_group ".
-	"WHERE top_group.$rankfield > 0 ".
-	"AND top_group.group_id=groups.group_id ".
-	"ORDER BY top_group.rank_$rankfield",100);
+$res_top = db_query("select g.unix_group_name, g.group_name, sum(s.$rankfield) as items "
+			." from stats_project s, groups g "
+			." where s.group_id = g.group_id "
+			." group by g.unix_group_name, g.group_name "
+			." order by items desc", 100);
 
 echo db_error();
 
+$display_rank = 0;
 while ($row_top = db_fetch_array($res_top)) {
 	$i++;
-	print '<tr '. $HTML->boxGetAltRowStyle($i) .'><td>  '.$row_top["rank_$rankfield"]
+	if ($row_top["items"] == 0) {
+		continue;
+	}
+	$display_rank++;
+	print '<tr '. $HTML->boxGetAltRowStyle($i) .'><td>  '.$display_rank
 		.'</td><td><a href="/projects/'. strtolower($row_top['unix_group_name']) .'/">'
 		.stripslashes($row_top['group_name'])."</a>"
-		.'</td><td align="right">'.$row_top["$rankfield"]
-		.'   </td><td align="right">'.$row_top["rank_$rankfield"."_old"]
+		.'</td><td align="right">'.$row_top['items']
 		.'   </td>'
 		.'<td align="right">';
-
-	// calculate change
-	$diff = $row_top["rank_$rankfield"."_old"] - $row_top["rank_$rankfield"];
-	if (($row_top["rank_$rankfield"."_old"] == 0) || ($row_top["rank_$rankfield"] == 0)) {
-		print $Language->getText('top','NA');
-	}
-	else if ($diff == 0) {
-		print $Language->getText('top','same');
-	}
-	else if ($diff > 0) {
-		print "<FONT color=\"#009900\">".$Language->getText('top','up',$diff)."</FONT>";
-	}
-	else if ($diff < 0) {
-		print "<FONT color=\"#CC0000\">".$Language->getText('top','down',(0-$diff))."</FONT>";
-	}
-
 	print '   </td></tr>
 ';
 }



More information about the evolvis-commits mailing list