[evolvis-commits] r9425: Replaced a 'select *' with a 'select count(*)' in forum monitoring SQL query↵

mirabilos at evolvis.org mirabilos at evolvis.org
Thu Feb 24 17:24:42 CET 2011


Author: mirabilos
Date: 2011-02-24 17:24:42 +0100 (Thu, 24 Feb 2011)
New Revision: 9425

Modified:
   trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog
   trunk/gforge_base/evolvisforge-5.1/gforge/common/forum/Forum.class
Log:
Replaced a 'select *' with a 'select count(*)' in forum monitoring SQL query


Modified: trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog	2011-02-24 16:24:41 UTC (rev 9424)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog	2011-02-24 16:24:42 UTC (rev 9425)
@@ -1,3 +1,7 @@
+2004-03-11  Tom Copeland <tom at infoether.com>
+	* SQL optimization: Replaced a 'select *' with a 'select count(*)'
+	in Forum.class.
+
 2004-03-08  Tom Copeland <tom at infoether.com>
 	* SQL optimization: Replaced 'select *' occurrences in User.class
 	and BaseLanguage.class.  Replaced a 'select *' with a 'select count(*)'

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/common/forum/Forum.class
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/common/forum/Forum.class	2011-02-24 16:24:41 UTC (rev 9424)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/common/forum/Forum.class	2011-02-24 16:24:42 UTC (rev 9425)
@@ -408,16 +408,10 @@
 		if (!session_loggedin()) {
 			return false;
 		}
-		$sql="SELECT * FROM forum_monitored_forums
-			WHERE user_id='".user_getid()."' AND forum_id='".$this->getID()."';";
-
+		$sql="SELECT count(*) FROM forum_monitored_forums WHERE user_id='".user_getid()."' AND forum_id='".$this->getID()."';";
 		$result = db_query($sql);
-
-		if (!$result || db_numrows($result) < 1) {
-			return false;
-		} else {
-			return true;
-		}
+    $row_count = db_fetch_array($result);
+		return $result && $row_count['count'] > 0;
 	}
 
 	/**



More information about the evolvis-commits mailing list