[evolvis-commits] r9434: SQL optimization: Replaced a 'select *' with a 'select count(*)' in Artifact. class↵

mirabilos at evolvis.org mirabilos at evolvis.org
Thu Feb 24 17:24:53 CET 2011


Author: mirabilos
Date: 2011-02-24 17:24:53 +0100 (Thu, 24 Feb 2011)
New Revision: 9434

Modified:
   trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog
   trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/Artifact.class
Log:
SQL optimization: Replaced a 'select *' with a 'select count(*)' in Artifact.class


Modified: trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog	2011-02-24 16:24:52 UTC (rev 9433)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/ChangeLog	2011-02-24 16:24:53 UTC (rev 9434)
@@ -2,6 +2,8 @@
 	* www/snippet/browse.php & detail.php: Replace user_name with realname,
 	added link to user's page. 
 	* Layout.class - added a createLinkToUserHome() function
+	* SQL optimization: Replaced a 'select *' with a 'select count(*)'
+	in Artifact.class.  
 
 2004-03-11  Tom Copeland <tom at infoether.com>
 	* SQL optimization: Replaced a 'select *' with a 'select count(*)'

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/Artifact.class
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/Artifact.class	2011-02-24 16:24:52 UTC (rev 9433)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/Artifact.class	2011-02-24 16:24:53 UTC (rev 9434)
@@ -552,16 +552,12 @@
 		if (!session_loggedin()) {
 			return false;
 		}
-		$sql="SELECT * FROM artifact_monitor WHERE user_id='".user_getid()."' AND artifact_id='".$this->getID()."';";
-		$result = db_query($sql);
-		if (!$result || db_numrows($result) < 1) {
-			return false;
-		} else {
-			return true;
-		}
+    $sql="SELECT count(*) FROM artifact_monitor WHERE user_id='".user_getid()."' AND artifact_id='".$this->getID()."';";
+    $result = db_query($sql);
+    $row_count = db_fetch_array($result);
+    return $result && $row_count['count'] > 0;
 	}
 
-
 	/**
 	 *  getMonitorIds - array of email addresses monitoring this Artifact.
 	 *



More information about the evolvis-commits mailing list