[evolvis-commits] r10056: fixed [#920] Problem accessing release notes of a private package↵
mirabilos at evolvis.org
mirabilos at evolvis.org
Thu Feb 24 17:37:01 CET 2011
Author: mirabilos
Date: 2011-02-24 17:37:01 +0100 (Thu, 24 Feb 2011)
New Revision: 10056
Modified:
trunk/gforge_base/evolvisforge-5.1/gforge/www/frs/shownotes.php
Log:
fixed [#920] Problem accessing release notes of a private package
Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/frs/shownotes.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/frs/shownotes.php 2011-02-24 16:36:59 UTC (rev 10055)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/frs/shownotes.php 2011-02-24 16:37:01 UTC (rev 10056)
@@ -28,20 +28,6 @@
require_once('pre.php');
require_once('www/frs/include/frs_utils.php');
-//
-// Members of projects can see all packages
-// Non-members can only see public packages
-//
-if (session_loggedin()) {
- if (user_ismember($group_id) || user_ismember(1,'A')) {
- $pub_sql='';
- } else {
- $pub_sql=' AND frs_package.is_public=1 ';
- }
-} else {
- $pub_sql=' AND frs_package.is_public=1 ';
-}
-
$result=db_query("SELECT frs_release.notes,frs_release.changes,
frs_release.preformatted,frs_release.name,frs_package.group_id,frs_package.is_public
FROM frs_release,frs_package
@@ -50,12 +36,20 @@
AND frs_release.release_id='$release_id'");
if (!$result || db_numrows($result) < 1) {
- echo db_error();
exit_error($Language->getText('general','error'), $Language->getText('project_shownotes','error_release_not_found'));
} else {
$group_id=db_result($result,0,'group_id');
+ $is_public =db_result($result,0,'is_public');
+ // Members of projects can see all packages
+ // Non-members can only see public packages
+ if(!$is_public) {
+ if (!session_loggedin() || (!user_ismember($group_id) && !user_ismember(1,'A'))) {
+ exit_permission_denied();
+ }
+ }
+
frs_header(array('title'=>$Language->getText('project_shownotes','title'),'group'=>$group_id,'pagename'=>'project_shownotes','sectionvals'=>array(group_getname($group_id))));
echo $HTML->boxTop($Language->getText('project_shownotes','notes'));
More information about the evolvis-commits
mailing list