[evolvis-commits] r11120: changed form_release_key($_POST['form_key']); to form_release_key (getStringFromRequest("form_key")); ↵

mirabilos at evolvis.org mirabilos at evolvis.org
Thu Feb 24 18:03:04 CET 2011


Author: mirabilos
Date: 2011-02-24 18:03:04 +0100 (Thu, 24 Feb 2011)
New Revision: 11120

Modified:
   trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/admin/index.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/forum.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/mail/admin/index.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/my/diary.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/people/admin/index.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editjob.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editprofile.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/register/projectinfo.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/addversion.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/package.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/submit.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/question.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/survey.php
Log:
changed   form_release_key($_POST['form_key']); to form_release_key(getStringFromRequest("form_key"));


Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/admin/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/admin/index.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/admin/index.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -112,19 +112,19 @@
 				Adding forums to this group
 			*/
 			if (!$p->isForumAdmin()) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_permission_denied();
 			}
 			$f=new Forum($g);
 			if (!$f || !is_object($f)) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error($Language->getText('general','error'),$Language->getText('forum_errors','error_getting_forum'));
 			} elseif ($f->isError()) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error($Language->getText('general','error'),$f->getErrorMessage());
 			}
 			if (!$f->create($forum_name,$description,$is_public,$send_all_posts_to,1,$allow_anonymous)) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error($Language->getText('general','error'),$f->getErrorMessage());
 			} else {
 				$feedback .= $Language->getText('forum_admin_addforum','forum_created');

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/forum.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/forum.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/forum.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -73,15 +73,15 @@
 
 		$fm=new ForumMessage($f);
 		if (!$fm || !is_object($fm)) {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			exit_error($Language->getText('general','error'), "Error getting new ForumMessage");
 		} elseif ($fm->isError()) {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			exit_error($Language->getText('general','error'),"Error getting new ForumMessage: ".$fm->getErrorMessage());
 		}
 
 		if (!$fm->create($subject, $body, $thread_id, $is_followup_to) || $fm->isError()) {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			exit_error($Language->getText('general','error'),'Error creating ForumMessage: '.$fm->getErrorMessage());
 		} else {
 			$feedback=$Language->getText('forum_forum','postsuccess');
@@ -96,10 +96,10 @@
 
 	$fmf = new ForumMessageFactory($f);
 	if (!$fmf || !is_object($fmf)) {
-		form_release_key($_POST['form_key']);
+		form_release_key(getStringFromRequest("form_key"));
 		exit_error($Language->getText('general','error'), "Error getting new ForumMessageFactory");
 	} elseif ($fmf->isError()) {
-		form_release_key($_POST['form_key']);
+		form_release_key(getStringFromRequest("form_key"));
 		exit_error($Language->getText('general','error'),$fmf->getErrorMessage());
 	}
 

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/mail/admin/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/mail/admin/index.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/mail/admin/index.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -44,10 +44,10 @@
 				exit_form_double_submit();
 			}
 			if(!$mailingList || !is_object($mailingList)) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error($Language->getText('general', 'error'), $Language->getText('mail_admin', 'error_getting_list'));
 			} elseif($mailingList->isError()) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error($Language->getText('general', 'error'), $mailingList->getErrorMessage());
 			}
 			
@@ -56,7 +56,7 @@
 				getStringFromPost('description'),
 				getIntFromPost('is_public', 1)
 			)) {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error($Language->getText('general', 'error'), $mailingList->getErrorMessage());
 			} else {
 				$feedback .= $Language->getText('mail_admin_addlist', 'list_added');

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/my/diary.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/my/diary.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/my/diary.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -57,7 +57,7 @@
 			if ($res && db_affected_rows($res) > 0) {
 				$feedback .= $Language->getText('my_diary','diary_updated');
 			} else {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				echo db_error();
 				$feedback .= $Language->getText('my_diary','nothing_updated');
 			}
@@ -105,7 +105,7 @@
 					//since this is a private note
 				}
 			} else {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				$feedback .= $Language->getText('my_diary','error_adding_item');
 				echo db_error();
 			}

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/people/admin/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/people/admin/index.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/people/admin/index.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -51,7 +51,7 @@
 			$result=db_query($sql);
 			if (!$result) {
 				echo db_error();
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				$feedback .= ' Error inserting value ';
 			}
 
@@ -66,7 +66,7 @@
 			$result=db_query($sql);
 			if (!$result) {
 				echo db_error();
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				$feedback .= ' Error inserting value ';
 			}
 

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editjob.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editjob.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editjob.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -60,7 +60,7 @@
 		if (!$result || db_affected_rows($result) < 1) {
 			$feedback .= $Language->getText('people_editjob','job_insert_failed');
 			echo db_error();
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 		} else {
 			$job_id=db_insertid($result,'people_job','job_id');
 			$feedback .= $Language->getText('people_editjob','job_insert_ok');

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editprofile.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editprofile.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/people/editprofile.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -37,7 +37,7 @@
 			"WHERE user_id='".user_getid()."'";
 		$result=db_query($sql);
 		if (!$result || db_affected_rows($result) < 1) {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			$feedback .= $Language->getText('people_editprofile','update_failed');
 			echo db_error();
 		} else {
@@ -84,7 +84,7 @@
 			   
 				$result=db_query($sql);
 				if (!$result || db_affected_rows($result) < 1) {
-					form_release_key($_POST['form_key']);
+					form_release_key(getStringFromRequest("form_key"));
 					echo db_error();
 					$feedback .= $Language->getText('people_editprofile','failed_to_add_skill');
 					echo '<h2>'.$Language->getText('people_editprofile','failed_to_add_skill').'<h2>';
@@ -93,7 +93,7 @@
 				}
 			}
 		} else {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			exit_error($Language->getText('people_editprofile','error'),$Language->getText('people_editprofile','fill_all_required_fields'));
 		}
 	}

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/register/projectinfo.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/register/projectinfo.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/register/projectinfo.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -65,7 +65,7 @@
 	$feedback = "";
 
 	if ($sys_use_scm && !$scm) {
-		form_release_key($_POST['form_key']);
+		form_release_key(getStringFromRequest("form_key"));
 		$feedback .= $Language->getText('register','scm_not_selected');
 	} else {
 		$scm_host = $sys_cvs_host;
@@ -90,7 +90,7 @@
 			$res = $group->setPluginUse($scm,true);
 		}
 		if (!$res) {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			$feedback .= $group->getErrorMessage();
 		} else {
 			$HTML->header(array('title'=>$Language->getText('register','registration_complete')));

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/addversion.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/addversion.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/addversion.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -58,7 +58,7 @@
 					$feedback .= $Language->getText('snippet_addversion','error_doing_snippet_version_insert');
 					echo db_error();
 				} else {
-					form_release_key($_POST['form_key']);
+					form_release_key(getStringFromRequest("form_key"));
 					$feedback .= $Language->getText('snippet_addversion','snippet_version_added_successfully');
 				}
 			} else {
@@ -183,7 +183,7 @@
 				}
 
 			} else {
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				exit_error( $Language->getText('snippet_addversion','error_go_back_and_fill_in_all'));
 			}
 

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/package.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/package.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/package.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -40,7 +40,7 @@
 			$result=db_query($sql);
 			if (!$result) {
 				//error in database
-				form_release_key($_POST['form_key']);
+				form_release_key(getStringFromRequest("form_key"));
 				$feedback .= $Language->getText('snippet_package','error_doing_snippet_package_insert');
 				snippet_header(array('title'=>$Language->getText('snippet_package','title')));
 				echo db_error();
@@ -108,7 +108,7 @@
 				}
 			}
 		} else {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			exit_error($Language->getText('general','error'),$Language->getText('snippet_package','error_go_back_and_fill'));
 		}
 

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/submit.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/submit.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/snippet/submit.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -63,7 +63,7 @@
 				}
 			}
 		} else {
-			form_release_key($_POST['form_key']);
+			form_release_key(getStringFromRequest("form_key"));
 			exit_error('Error','Error - Go back and fill in all the information');
 		}
 

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/question.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/question.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/question.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -75,7 +75,7 @@
     /* Error */
     if ( $sq->isError()) {
 	$msg = $sq->getErrorMessage();
-	form_release_key($_POST['form_key']);
+	form_release_key(getStringFromRequest("form_key"));
     }
     
     echo "<H3>".$msg ."</H3>";

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/survey.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/survey.php	2011-02-24 17:03:03 UTC (rev 11119)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/survey/admin/survey.php	2011-02-24 17:03:04 UTC (rev 11120)
@@ -71,7 +71,7 @@
 /* Error on previous transactions? */
 if ($s->isError()) {
     $feedback = $s->getErrorMessage();
-    form_release_key($_POST['form_key']);
+    form_release_key(getStringFromRequest("form_key"));
 } 
 
 echo ($sh->ShowAddSurveyForm($s));



More information about the evolvis-commits mailing list