[evolvis-commits] r12572: cleanup notice messages

mirabilos at evolvis.org mirabilos at evolvis.org
Mon Feb 28 01:47:29 CET 2011


Author: mirabilos
Date: 2011-02-28 01:47:26 +0100 (Mon, 28 Feb 2011)
New Revision: 12572

Modified:
   trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/ArtifactType.class.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/admin/index.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/doceditor.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/include/ForumHTML.class.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/news/admin/index.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/news/submit.php
   trunk/gforge_base/evolvisforge-5.1/gforge/www/project/admin/index.php
Log:
cleanup notice messages

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/ArtifactType.class.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/ArtifactType.class.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/common/tracker/ArtifactType.class.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -746,7 +746,7 @@
 		if ($choiceid == 100) {
 			return 'None';
 		}
-		if (!$this->element_name["$choiceid"]) {
+		if (!isset($this->element_name["$choiceid"])) {
 			$sql="select element_id,extra_field_id,element_name
 				FROM artifact_extra_field_elements
 				WHERE element_id IN ($choiceid)";

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/admin/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/admin/index.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/admin/index.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -220,6 +220,7 @@
 		//echo '<input type="hidden" name="editor" value="editor">';
 		echo _('Edit the contents to your desire or leave them as they are to remain unmodified.');
 		/*
+		$GLOBALS['editor_was_set_up']=false;
 		$params = array () ;
 		$params['name'] = 'data';
 		$params['width'] = "800";

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/doceditor.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/doceditor.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/docman/doceditor.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -53,6 +53,7 @@
 ';
 echo '</script>';
 echo '<form name="theform">';
+$GLOBALS['editor_was_set_up']=false;
 $params = array () ;
 $params['body'] = '';
 $params['name'] = 'data';
@@ -62,21 +63,20 @@
 plugin_hook("text_editor",$params);
 $editor = true;
 if (!$GLOBALS['editor_was_set_up']) {
-	//if we don�t have any plugin for text editor, display a simple textarea edit box
+	//if we don't have any plugin for text editor, display a simple textarea edit box
 	$editor = false;
 	echo '<textarea name="data" rows="15" cols="100" wrap="soft"></textarea><br />';
 	echo '<script>	
 			window.document.theform.data.value = window.opener.document.adddata.data.value;
 		</script>';
 } else {
-	// we must make it wait a bit or else the fckeditor object won�t be set yet
+	// we must make it wait a bit or else the fckeditor object won't be set yet
 	echo '<script type="text/javascript">
 		setTimeout("setEditorValue(\'data\',window.opener.document.adddata.data.value)",2250);
 	</script>
 	';
 }
 
-
 unset($GLOBALS['editor_was_set_up']);
 
 if ($editor) {

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/include/ForumHTML.class.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/include/ForumHTML.class.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/forum/include/ForumHTML.class.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -488,7 +488,8 @@
 		<br>
 		<strong><?php echo _('Message:'); ?></strong><?php echo notepad_button('document.forms[1].body') ?><?php echo utils_requiredField(); ?><br />
 		<?php
-                $params = array() ;
+		$GLOBALS['editor_was_set_up']=false;
+		$params = array() ;
 		$params['body'] = $body;
 		$params['width'] = "800";
 		$params['height'] = "500";
@@ -560,14 +561,14 @@
 
 		<?php
 		$GLOBALS['editor_was_set_up']=false;
-                $params = array();
+		$params = array();
 		$params['body'] = $body;
 		$params['width'] = "800";
 		$params['height'] = "500";
 		$params['group'] = $group_id;
 		plugin_hook("text_editor",$params);
 		if (!$GLOBALS['editor_was_set_up']) {
-			//if we don�t have any plugin for text editor, display a simple textarea edit box
+			//if we don't have any plugin for text editor, display a simple textarea edit box
 			echo '<textarea name="body"  rows="10" cols="50" wrap="soft">' . $body . '</textarea>';
 		}
 		unset($GLOBALS['editor_was_set_up']);

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/news/admin/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/news/admin/index.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/news/admin/index.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -136,6 +136,7 @@
 		<input type="text" name="summary" value="'.db_result($result,0,'summary').'" size="30" maxlength="60"><br />
 		<strong>'._('Details').'</strong>'.notepad_button('document.forms[1].details').'<br />';
 		
+		$GLOBALS['editor_was_set_up']=false;
 		$params = array () ;
 		$params['name'] = 'details';
 		$params['width'] = "600";
@@ -143,7 +144,7 @@
 		$params['group'] = $group_id;
 		$params['body'] = db_result($result,0,'details');
 		plugin_hook("text_editor",$params);
-		if (!isset($GLOBALS['editor_was_set_up'])) {
+		if (!$GLOBALS['editor_was_set_up']) {
 			//if we don't have any plugin for text editor, display a simple textarea edit box
 			echo '<textarea name="details" rows="5" cols="50" wrap="soft">'.db_result($result,0,'details').'</textarea><br />';
 		}
@@ -280,6 +281,7 @@
 		<input type="text" name="summary" value="'.db_result($result,0,'summary').'" size="30" maxlength="60" /><br />
 		<strong>'._('Details').':</strong><br />';
 		
+		$GLOBALS['editor_was_set_up']=false;
 		$params = array () ;
 		$params['name'] = 'details';
 		$params['width'] = "600";
@@ -288,7 +290,7 @@
 		$params['body'] = db_result($result,0,'details');
 		plugin_hook("text_editor",$params);
 		if (!$GLOBALS['editor_was_set_up']) {
-			//if we don�t have any plugin for text editor, display a simple textarea edit box
+			//if we don't have any plugin for text editor, display a simple textarea edit box
 			echo '<textarea name="details" rows="5" cols="50" wrap="soft">'.db_result($result,0,'details').'</textarea><br />';
 		}
 		unset($GLOBALS['editor_was_set_up']);		

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/news/submit.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/news/submit.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/news/submit.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -118,6 +118,7 @@
 		<p>
 		<strong>'._('Details').':</strong>'.notepad_button('document.forms[1].details').utils_requiredField().'<br />';
 	
+	$GLOBALS['editor_was_set_up']=false;
 	$params = array() ;
 	$params['name'] = 'details';
 	$params['width'] = "600";
@@ -125,7 +126,7 @@
 	$params['body'] = "";
 	$params['group'] = $group_id;
 	plugin_hook("text_editor",$params);
-	if (!isset($GLOBALS['editor_was_set_up'])) {
+	if (!$GLOBALS['editor_was_set_up']) {
 		//if we don't have any plugin for text editor, display a simple textarea edit box
 		echo '<textarea name="details" rows="5" cols="50"></textarea><br />';
 	}

Modified: trunk/gforge_base/evolvisforge-5.1/gforge/www/project/admin/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/gforge/www/project/admin/index.php	2011-02-28 00:47:22 UTC (rev 12571)
+++ trunk/gforge_base/evolvisforge-5.1/gforge/www/project/admin/index.php	2011-02-28 00:47:26 UTC (rev 12572)
@@ -319,7 +319,7 @@
 		<form action="<?php echo getStringFromServer('PHP_SELF').'?group_id='.$group_id; ?>" method="post">
 		<input type="hidden" name="submit" value="y" />
 		<input type="hidden" name="form_userid" value="<?php echo $user->getId(); ?>" />
-		<tr><td><input type="hidden" name="form_unix_name" value="<?php echo $user->getUnixName(); ?>" /><?php echo util_make_link_u ($user->getUnixName(),$user->getId,$user->getRealName()); ?></td>
+		<tr><td><input type="hidden" name="form_unix_name" value="<?php echo $user->getUnixName(); ?>" /><?php echo util_make_link_u ($user->getUnixName(),$user->getId(),$user->getRealName()); ?></td>
 		<td><?php echo role_box($group_id,'role_id',$row_memb['role_id']); ?>
 			<input type="submit" name="acceptpending" value="<?php echo _('Accept') ?>" />
 			<input type="submit" name="rejectpending" value="<?php echo _('Reject') ?>" /></td>



More information about the evolvis-commits mailing list