[evolvis-commits] r14528: Added deprecation tests for old-style configuration items

mirabilos at evolvis.org mirabilos at evolvis.org
Mon Feb 28 04:21:25 CET 2011


Author: mirabilos
Date: 2011-02-28 04:21:24 +0100 (Mon, 28 Feb 2011)
New Revision: 14528

Modified:
   trunk/gforge_base/evolvisforge-5.1/tests/code/deprecations/DeprecationsTests.php
Log:
Added deprecation tests for old-style configuration items

Modified: trunk/gforge_base/evolvisforge-5.1/tests/code/deprecations/DeprecationsTests.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/tests/code/deprecations/DeprecationsTests.php	2011-02-28 03:21:22 UTC (rev 14527)
+++ trunk/gforge_base/evolvisforge-5.1/tests/code/deprecations/DeprecationsTests.php	2011-02-28 03:21:24 UTC (rev 14528)
@@ -26,6 +26,25 @@
 		$this->assertEquals('', $output);
 	}
 	
+	/**
+	 * Check that no code uses configuration items from global variables
+	 */
+	public function testconfig_vars()
+	{
+		$vars = array ('sys_name',
+			       'sys_user_reg_restricted') ;
+		
+		foreach ($vars as $v) {		
+			$output = `cd .. ; find gforge tests -name '*.php' -type f | xargs pcregrep -l '\\$$v' \
+					   | grep -v ^gforge/www/include/pre.php`;
+			$this->assertEquals('', $output, "Found deprecated variable $$v:");
+
+			$output = `cd .. ; find gforge tests -name '*.php' -type f | xargs pcregrep -n '\\\$GLOBALS\\[.?$v.?\\]' \
+					   | grep -v ^gforge/www/include/pre.php`;
+			$this->assertEquals('', $output, "Found deprecated variable \$GLOBALS['$v']:");
+		}
+	}
+	
 // Local Variables:
 // mode: php
 // c-file-style: "bsd"



More information about the evolvis-commits mailing list