[evolvis-commits] r17298: XHTML and PHP fixes

mirabilos at evolvis.org mirabilos at evolvis.org
Fri Jun 10 16:30:46 CEST 2011


Author: mirabilos
Date: 2011-06-10 16:30:46 +0200 (Fri, 10 Jun 2011)
New Revision: 17298

Modified:
   trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php
   trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php
Log:
XHTML and PHP fixes

Modified: trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php	2011-06-10 14:24:34 UTC (rev 17297)
+++ trunk/gforge_base/evolvisforge/gforge/common/tracker/Artifact.class.php	2011-06-10 14:30:46 UTC (rev 17298)
@@ -1197,7 +1197,7 @@
 				$type=$ef[$arr['extra_field_id']]['field_type'];
 				if (($type == ARTIFACT_EXTRAFIELDTYPE_CHECKBOX) || ($type==ARTIFACT_EXTRAFIELDTYPE_MULTISELECT)) {
 					//accumulate a sub-array of values in cases where you may have multiple rows
-					if (!is_array($this->extra_field_data[$arr['extra_field_id']])) {
+					if (!is_array(util_ifsetor($this->extra_field_data[$arr['extra_field_id']]))) {
 						$this->extra_field_data[$arr['extra_field_id']] = array();
 					}
 					$this->extra_field_data[$arr['extra_field_id']][]=$arr['field_data'];

Modified: trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php	2011-06-10 14:24:34 UTC (rev 17297)
+++ trunk/gforge_base/evolvisforge/gforge/www/tracker/include/ArtifactTypeHtml.class.php	2011-06-10 14:30:46 UTC (rev 17298)
@@ -285,6 +285,8 @@
 			$text_100=_('None');
 		}
 		$arr = $this->getExtraFieldElements($extra_field_id);
+		$keys = array();
+		$vals = array();
 		for ($i=0; $i<count($arr); $i++) {
 			$keys[$i]=$arr[$i]['element_id'];
 			$vals[$i]=$arr[$i]['element_name'];
@@ -327,15 +329,16 @@
 			$checked=array();
 		}
 		$arr = $this->getExtraFieldElements($extra_field_id);
+		$return = "";
 		if ($show_100) {
 			$return .= '
 				<input type="checkbox" name="extra_fields['.$extra_field_id.'][]" value="100" '.
-			((in_array(100,$checked)) ? 'CHECKED' : '').'/>'.$text_100.'<br />';
+			((in_array(100,$checked)) ? 'checked="checked" ' : '').'/>'.$text_100.'<br />';
 		}
 		for ($i=0; $i<count($arr); $i++) {
 			$return .= '
 				<input type="checkbox" name="extra_fields['.$extra_field_id.'][]" value="'.$arr[$i]['element_id'].'" '.
-			((in_array($arr[$i]['element_id'],$checked)) ? 'CHECKED' : '').'/> '.$arr[$i]['element_name'].'<br />';
+			((in_array($arr[$i]['element_id'],$checked)) ? 'checked="checked" ' : '').'/> '.$arr[$i]['element_name'].'<br />';
 		}
 		return $return;
 	}



More information about the evolvis-commits mailing list