[evolvis-commits] r16631: Error messages should use the error class, not h1↵ Success me =?UTF-8?Q?ssages=20should=20use=20the?==?UTF-8?Q?=20feedback=20class?=, not h1

mirabilos at evolvis.org mirabilos at evolvis.org
Tue Mar 1 01:28:53 CET 2011


Author: mirabilos
Date: 2011-03-01 01:28:53 +0100 (Tue, 01 Mar 2011)
New Revision: 16631

Modified:
   trunk/gforge_base/evolvisforge-5.1/src/www/people/people_utils.php
   trunk/gforge_base/evolvisforge-5.1/src/www/snippet/add_snippet_to_package.php
   trunk/gforge_base/evolvisforge-5.1/src/www/snippet/delete.php
Log:
Error messages should use the error class, not h1
Success messages should use the feedback class, not h1

Modified: trunk/gforge_base/evolvisforge-5.1/src/www/people/people_utils.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/people/people_utils.php	2011-03-01 00:28:50 UTC (rev 16630)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/people/people_utils.php	2011-03-01 00:28:53 UTC (rev 16631)
@@ -5,6 +5,7 @@
  * Copyright 1999-2001 (c) VA Linux Systems
  * Copyright 2002-2004 (c) GForge Team
  * Copyright 2010 (c) Franck Villaume
+ * Copyright (C) 2010 Alain Peyrat - Alcatel-Lucent
  * http://fusionforge.org/
  *
  * This file is part of FusionForge.
@@ -109,7 +110,7 @@
 		}
 		}
 	} else {
-		echo '<h1>'._('You must be logged in first').'</h1>';
+		echo '<p class="error">You must be logged in first</p>';
 	}
 }
 
@@ -217,7 +218,7 @@
 		}
 
 	} else {
-		echo '<h1>'._('You must be logged in first').'</h1>';
+		echo '<p class="error">You must be logged in first</p>';
 	}
 }
 

Modified: trunk/gforge_base/evolvisforge-5.1/src/www/snippet/add_snippet_to_package.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/snippet/add_snippet_to_package.php	2011-03-01 00:28:50 UTC (rev 16630)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/snippet/add_snippet_to_package.php	2011-03-01 00:28:53 UTC (rev 16631)
@@ -3,6 +3,7 @@
  * Code Snippets Repository
  *
  * Copyright 1999-2001 (c) VA Linux Systems
+ * Copyright (C) 2010 Alain Peyrat - Alcatel-Lucent
  * http://fusionforge.org
  *
  * This file is part of FusionForge.
@@ -53,7 +54,7 @@
 
 	if (!$snippet_package_version_id) {
 		//make sure the package id was passed in
-		echo '<h1>' ._('Error - snippet_package_version_id missing') .'</h1>';
+		echo '<p class="error">' ._('Error - snippet_package_version_id missing') .'</p>';
 		handle_add_exit();
 	}
 
@@ -69,7 +70,7 @@
 				"WHERE submitted_by=$1 AND ".
 				"snippet_package_version_id=$2", array(user_getid(), $snippet_package_version_id));
 			if (!$result || db_numrows($result) < 1) {
-				echo '<h1>' ._('Error - Only the creator of a package version can add snippets to it.').'</h1>';
+				echo '<p class="error">' ._('Error - Only the creator of a package version can add snippets to it.').'</p>';
 				handle_add_exit();
 			}
 
@@ -79,7 +80,7 @@
 			$result=db_query_params ('SELECT * FROM snippet_version WHERE snippet_version_id=$1',
 			array($snippet_version_id));
 			if (!$result || db_numrows($result) < 1) {
-				echo '<h1>' ._('Error - That snippet doesn\'t exist.').'</h1>';
+				echo '<p class="error">' ._('Error - That snippet doesn\'t exist.').'</p>';
 				echo util_make_link ('/snippet/add_snippet_to_package.php?snippet_package_version_id='.$snippet_package_version_id,_('Back To Add Page'));
 				handle_add_exit();
 			}
@@ -93,7 +94,7 @@
 			array($snippet_package_version_id,
 				$snippet_version_id));
 			if ($result && db_numrows($result) > 0) {
-				echo '<h1>'._('Error - That snippet was already added to this package.').'</h1>';
+				echo '<p class="error">'._('Error - That snippet was already added to this package.').'</p>';
 				echo util_make_url ('/snippet/add_snippet_to_package.php?snippet_package_version_id='.$snippet_package_version_id,_('Back To Add Page'));
 				handle_add_exit();
 			}
@@ -111,7 +112,7 @@
 				$feedback .= _('Snippet Version Added Successfully.');
 			}
 		} else {
-			echo '<h1>' ._('Error - Go back and fill in all the information').'</h1>';
+			echo '<p class="error">' ._('Error - Go back and fill in all the information').'</p>';
 			echo util_make_link ('/snippet/add_snippet_to_package.php?snippet_package_version_id='.$snippet_package_version_id,_('Back To Add Page'));
 			handle_add_exit();
 		}

Modified: trunk/gforge_base/evolvisforge-5.1/src/www/snippet/delete.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/snippet/delete.php	2011-03-01 00:28:50 UTC (rev 16630)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/snippet/delete.php	2011-03-01 00:28:53 UTC (rev 16631)
@@ -3,6 +3,7 @@
  * Code Snippets Repository
  *
  * Copyright 1999-2001 (c) VA Linux Systems - Tim Perdue
+ * Copyright (C) 2010 Alain Peyrat - Alcatel-Lucent
  * http://fusionforge.org
  *
  * This file is part of FusionForge.
@@ -45,7 +46,7 @@
 			"WHERE submitted_by=$1 AND ".
 			"snippet_package_version_id=$2", array(user_getid(), $snippet_package_version_id));
 		if (!$result || db_numrows($result) < 1) {
-			echo '<h1>Error - Only the creator of a package version can delete snippets from it.</h1>';
+			echo '<p class="error">Error - Only the creator of a package version can delete snippets from it.</p>';
 			snippet_footer(array());
 			exit;
 		} else {
@@ -57,11 +58,11 @@
 			array($snippet_version_id,
 				$snippet_package_version_id));
 			if (!$result || db_affected_rows($result) < 1) {
-				echo '<h1>Error - That snippet doesn\'t exist in this package.</h1>';
+				echo '<p class="error">Error - That snippet doesn\'t exist in this package.</p>';
 				snippet_footer(array());
 				exit;
 			} else {
-				echo '<h1>Item Removed From Package</h1>';
+				echo '<p class="feedback">Item Removed From Package</p>';
 				snippet_footer(array());
 				exit;
 			}
@@ -76,7 +77,7 @@
 		$result=db_query_params("SELECT * FROM snippet_version ".
 			"WHERE snippet_version_id=$1 AND submitted_by=$2", array($snippet_version_id, user_getid()));
 		if (!$result || db_numrows($result) < 1) {
-			echo '<h1>Error - That snippet doesn\'t exist.</h1>';
+			echo '<p class="error">Error - That snippet doesn\'t exist.</p>';
 			snippet_footer(array());
 			exit;
 		} else {
@@ -94,7 +95,7 @@
 				$result=db_query_params("DELETE FROM snippet WHERE snippet_id=$1",array($snippet_id));
 			}
 
-			echo '<h1>Snippet Removed</h1>';
+			echo '<class="feedback">Snippet Removed</p>';
 			snippet_footer(array());
 			exit;
 		}
@@ -111,7 +112,7 @@
 			"snippet_package_version_id=$2", array(user_getid(), $snippet_package_version_id));
 		if (!$result || db_numrows($result) < 1) {
 			//they don't own it or it's not found
-			echo '<h1>Error - Only the creator of a package version can delete it.</h1>';
+			echo '<p class="error">Error - Only the creator of a package version can delete it.</p>';
 			snippet_footer(array());
 			exit;
 		} else {
@@ -134,7 +135,7 @@
 				//delete the main package even if the user didn't create it
 				$result=db_query_params("DELETE FROM snippet_package WHERE snippet_package_id=$1", array($snippet_package_id));
 			}
-			echo '<h1>Package Removed</h1>';
+			echo '<p class="feedback">Package Removed</p>';
 			snippet_footer(array());
 			exit;
 		}



More information about the evolvis-commits mailing list