[evolvis-commits] r17581: we remove dead code instead of commenting it out↵ and document the reasons for it in the SVN commit message

mirabilos at evolvis.org mirabilos at evolvis.org
Wed Oct 5 11:52:28 CEST 2011


Author: mirabilos
Date: 2011-10-05 11:52:28 +0200 (Wed, 05 Oct 2011)
New Revision: 17581

Modified:
   trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php
Log:
we remove dead code instead of commenting it out
and document the reasons for it in the SVN commit message


Modified: trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php
===================================================================
--- trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php	2011-10-05 09:51:38 UTC (rev 17580)
+++ trunk/gforge_base/evolvisforge/gforge/common/pm/ProjectTask.class.php	2011-10-05 09:52:28 UTC (rev 17581)
@@ -1000,18 +1000,6 @@
 			return false;
 		}
 
-		/* We should remove out commented source code if not needed anymore or 
-		 * comment the reason why it is still in the source code */
-		/*if ( ($this->getSummary() != $summary) || ($this->getDetails() != $details) ||
-			 ($this->getPriority() != $priority) || ($this->getHours() != $hours) ||
-			 ($this->getStartDate() != $start_date) || ($this->getEndDate() != $end_date) ||
-			 ($this->getStatusID() != $status_id) || ($this->getCategoryID() != $category_id) ||
-			 ($this->getPercentComplete() != $percent_complete) ) {
-
-			 $has_changes = true;
-		}*/
-
-
 		db_begin();
 
 		//



More information about the evolvis-commits mailing list