[evolvis-commits] r17592: #1824 Fixed. Permission check was broken, Table was rendered incorrectly.

messer at evolvis.org messer at evolvis.org
Fri Oct 14 12:31:29 CEST 2011


Author: messer
Date: 2011-10-14 12:31:29 +0200 (Fri, 14 Oct 2011)
New Revision: 17592

Modified:
   trunk/gforge_base/evolvisforge-5.1/src/www/tracker/include/ArtifactTypeHtml.class.php
Log:
#1824 Fixed. Permission check was broken, Table was rendered incorrectly.

Modified: trunk/gforge_base/evolvisforge-5.1/src/www/tracker/include/ArtifactTypeHtml.class.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/tracker/include/ArtifactTypeHtml.class.php	2011-10-12 06:45:47 UTC (rev 17591)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/tracker/include/ArtifactTypeHtml.class.php	2011-10-14 10:31:29 UTC (rev 17592)
@@ -294,8 +294,8 @@
 		}
 
 		$taskcount = db_numrows($ah->getRelatedTasks());
-		
-		if (forge_check_perm ('tracker_admin', $this->ArtifactType->Group->getID())) {
+
+		if (forge_check_perm ('tracker_admin', $this->Group->getID())) {
 			$is_admin=false;
 		} else {
 			$is_admin=true;
@@ -307,7 +307,6 @@
 			echo '<tr><td colspan="2">';
 			echo '<b>'._("Related Tasks").':</b>'.'<br/>';
 			$title_arr = array();
-			$title_arr[] = _('Task Id');
 			$title_arr[] = _('Task Summary');
 			$title_arr[] = _('Start Date');
 			$title_arr[] = _('End Date');
@@ -315,7 +314,7 @@
 			(($is_admin) ? $title_arr[]=_('Remove Relation') : '');
 			echo $GLOBALS['HTML']->listTableTop($title_arr);
 
-			echo '<table cellspacing="0">';
+			//echo '<table cellspacing="0">';
 			for ($i = 0; $i < $taskcount; $i++) {
 				$taskinfo  = db_fetch_array($ah->relatedtasks, $i);
 				$totalPercentage += $taskinfo['percent_complete'];
@@ -335,6 +334,7 @@
 					(($is_admin) ? '<td><input type="checkbox" name="remlink[]" value="'.$taskid.'" /></td>' : '').
 					'</tr>';
 			}
+                        echo '</table>';
 			echo $GLOBALS['HTML']->listTableBottom();
 
 			echo "\n<hr /><p style=\"text-align:right;\">";



More information about the evolvis-commits mailing list