[evolvis-commits] r17675: xhtml-improvements pending merges:↵ Thorsten Glaser 2011-10-31 td has no cellspacing; fix XML nesting↵ Thorsten Glaser 2011-10-31 defer table header emission until first row is actually written here,...

mirabilos at evolvis.org mirabilos at evolvis.org
Mon Oct 31 15:44:38 CET 2011


Author: mirabilos
Date: 2011-10-31 15:44:38 +0100 (Mon, 31 Oct 2011)
New Revision: 17675

Modified:
   trunk/gforge_base/evolvisforge-5.1/src/www/activity/index.php
   trunk/gforge_base/evolvisforge-5.1/src/www/search/include/renderers/AdvancedSearchHtmlSearchRenderer.class.php
Log:
xhtml-improvements pending merges:
  Thorsten Glaser 2011-10-31 td has no cellspacing; fix XML nesting
    Thorsten Glaser 2011-10-31 defer table header emission until first row is actually written here,...


Modified: trunk/gforge_base/evolvisforge-5.1/src/www/activity/index.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/activity/index.php	2011-10-31 14:44:32 UTC (rev 17674)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/activity/index.php	2011-10-31 14:44:38 UTC (rev 17675)
@@ -250,7 +250,7 @@
 		$theader[]=_('Activity');
 		$theader[]=_('By');
 
-		echo $HTML->listTableTop($theader);
+		$header_written = false;
 
 		$j=0;
 		$last_day = 0;
@@ -258,6 +258,10 @@
 			if (!check_perm_for_activity($arr)) {
 				continue;
 			}
+			if (!$header_written) {
+				echo $HTML->listTableTop($theader);
+				$header_written = true;
+			}
 			if ($last_day != strftime($date_format,$arr['activity_date'])) {
 				//	echo $HTML->listTableBottom($theader);
 				echo '<tr class="tableheading"><td colspan="3">'.strftime($date_format,$arr['activity_date']).'</td></tr>';
@@ -312,7 +316,9 @@
 			echo '</td></tr>';
 		}
 
-		echo $HTML->listTableBottom($theader);
+		if ($header_written) {
+			echo $HTML->listTableBottom($theader);
+		}
 	}
 }
 

Modified: trunk/gforge_base/evolvisforge-5.1/src/www/search/include/renderers/AdvancedSearchHtmlSearchRenderer.class.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/search/include/renderers/AdvancedSearchHtmlSearchRenderer.class.php	2011-10-31 14:44:32 UTC (rev 17674)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/search/include/renderers/AdvancedSearchHtmlSearchRenderer.class.php	2011-10-31 14:44:38 UTC (rev 17675)
@@ -413,7 +413,7 @@
 			$return .= '<table style="border:1px solid grey;" width="100%" border="0" cellpadding="1" cellspacing="0">
 							<tr><td><table width="90%" border="0" cellspacing="0" cellpadding="3">
 							<tr>
-								<td cellspacing="0">
+								<td>
 									<a href="#'.$key.'">'.$group_subsection_names[$key].'</a>'
 				.'	</td>
 								<td align="right">'
@@ -427,7 +427,7 @@
 				$return .= '		<input type="checkbox" name="'.urlencode($key).'"';
 				if (isset($GLOBALS[urlencode($key)]))
 					$return .= ' checked="checked" ';
-				$return .= ' /></input>'.$group_subsection_names[$key].'<br />';
+				$return .= ' />'.$group_subsection_names[$key].'<br />';
 			}
 			else
 				foreach($section as $underkey => $undersection) {



More information about the evolvis-commits mailing list