[evolvis-commits] r18334: “while (!$i = 16) {” is NOT a valid loop

mirabilos at evolvis.org mirabilos at evolvis.org
Thu Apr 12 10:42:10 CEST 2012


Author: mirabilos
Date: 2012-04-12 10:42:10 +0200 (Thu, 12 Apr 2012)
New Revision: 18334

Modified:
   trunk/gforge_base/evolvisforge-5.1/src/common/include/account.php
Log:
“while (!$i = 16) {” is NOT a valid loop

… although I believe the Blowfish Crypt support in here looks
totally broken, anyway

Modified: trunk/gforge_base/evolvisforge-5.1/src/common/include/account.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/common/include/account.php	2012-04-12 08:42:04 UTC (rev 18333)
+++ trunk/gforge_base/evolvisforge-5.1/src/common/include/account.php	2012-04-12 08:42:10 UTC (rev 18334)
@@ -184,11 +184,10 @@
 			$salt = "$1$" . "$a$b";
 			break;
 		case 'Blowfish':
-			$i = 0;
-			while (!$i = 16) {
+			$salt = '$2a$';
+			for ($i = 0; $i < 16; ++$i) {
 			 	$salt .= rand(64,126);
-			 	$i++;
-			 }
+			}
 			return "$2a$".$salt;
 			break;
 	}



More information about the evolvis-commits mailing list