[evolvis-commits] r18217: [#2932] tracker-power-query pending merges:↵ Thorsten Glaser 2012-03-30 [#2932] Allow multiple submitters in the Old Power Query

mirabilos at evolvis.org mirabilos at evolvis.org
Fri Mar 30 18:44:53 CEST 2012


Author: mirabilos
Date: 2012-03-30 18:44:53 +0200 (Fri, 30 Mar 2012)
New Revision: 18217

Modified:
   trunk/gforge_base/evolvisforge-5.1/src/common/tracker/ArtifactFactory.class.php
   trunk/gforge_base/evolvisforge-5.1/src/debian/changelog
Log:
[#2932] tracker-power-query pending merges:
  Thorsten Glaser 2012-03-30 [#2932] Allow multiple submitters in the Old Power Query


Modified: trunk/gforge_base/evolvisforge-5.1/src/common/tracker/ArtifactFactory.class.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/common/tracker/ArtifactFactory.class.php	2012-03-30 15:44:48 UTC (rev 18216)
+++ trunk/gforge_base/evolvisforge-5.1/src/common/tracker/ArtifactFactory.class.php	2012-03-30 16:44:53 UTC (rev 18217)
@@ -244,6 +244,7 @@
 				if (is_array($_assigned_to)) {
 					$_assigned_to='';
 				}
+				//XXX same as ↑ for submitted_by?
 				$aux_extra_fields = array();
 				if (is_array($_extra_fields)){
 					//print_r($_extra_fields);
@@ -404,10 +405,22 @@
 			}
 		}
 
-		if ($this->submitted_by && ($this->submitted_by != 0)) {
+		if ($this->submitted_by) {
 			//for open tasks, add status=100 to make sure we show all
-			$wheresql .= ' AND submitted_by=$'.$paramcount++ ;
-			$params[] = $this->submitted_by;
+			if (is_array($this->submitted_by)) {
+				$wheresql .= ' AND submitted_by = ANY ($' . $paramcount++;
+				$params[] = db_int_array_to_any_clause($this->submitted_by);
+				/*
+				 * eh. why is this a separate string
+				 * concatenation? and why does this
+				 * not use db_construct_qpa, anyway?
+				 * --mirabilos
+				 */
+				$wheresql .= ')';
+			} else {
+				$wheresql .= ' AND submitted_by = $' . $paramcount++;
+				$params[] = $this->submitted_by;
+			}
 		}
 
 		if ($this->last_changed > 0) {

Modified: trunk/gforge_base/evolvisforge-5.1/src/debian/changelog
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/debian/changelog	2012-03-30 15:44:48 UTC (rev 18216)
+++ trunk/gforge_base/evolvisforge-5.1/src/debian/changelog	2012-03-30 16:44:53 UTC (rev 18217)
@@ -32,8 +32,9 @@
   * [#2946] Correctly unencode entities before sending out mails
   * Tracker: multi-line Item Description and Comments handled correctly
   * [#2942] Rewrite Site-Admin Group List page
+  * [#2932] Allow multiple Submitters in Old Power Queries
 
- -- Thorsten Glaser <t.glaser at tarent.de>  Fri, 30 Mar 2012 17:40:56 +0200
+ -- Thorsten Glaser <t.glaser at tarent.de>  Fri, 30 Mar 2012 18:00:13 +0200
 
 fusionforge (5.1.1+evolvis49) unstable; urgency=low
 



More information about the evolvis-commits mailing list