[evolvis-commits] r18682: [#3191] Fix sending out tracker mails when a value is empty

mirabilos at evolvis.org mirabilos at evolvis.org
Thu Oct 4 11:58:08 CEST 2012


Author: mirabilos
Date: 2012-10-04 11:58:07 +0200 (Thu, 04 Oct 2012)
New Revision: 18682

Modified:
   trunk/gforge_base/evolvisforge-5.1/src/common/tracker/Artifact.class.php
   trunk/gforge_base/evolvisforge-5.1/src/debian/changelog
Log:
[#3191] Fix sending out tracker mails when a value is empty

Modified: trunk/gforge_base/evolvisforge-5.1/src/common/tracker/Artifact.class.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/common/tracker/Artifact.class.php	2012-10-04 09:58:03 UTC (rev 18681)
+++ trunk/gforge_base/evolvisforge-5.1/src/common/tracker/Artifact.class.php	2012-10-04 09:58:07 UTC (rev 18682)
@@ -1359,19 +1359,35 @@
 					}
 					$update = true;
 				}
+
+				if (!$extra_fields[$efid] &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_SELECT &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_RADIO &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_MULTISELECT &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_CHECKBOX) {
+					/* text fields are just purged and skipped */
+					continue;
+				}
 			} else {
 
-//no history for this extra field exists
+				// no history for this extra field exists
 
-			}
+				if (!$extra_fields[$efid] &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_SELECT &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_RADIO &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_MULTISELECT &&
+				    $type != ARTIFACT_EXTRAFIELDTYPE_CHECKBOX) {
+					/* text fields are just purged and skipped */
+					continue;
+				}
 
-			if (!$extra_fields[$efid] &&
-			    $type != ARTIFACT_EXTRAFIELDTYPE_SELECT &&
-			    $type != ARTIFACT_EXTRAFIELDTYPE_RADIO &&
-			    $type != ARTIFACT_EXTRAFIELDTYPE_MULTISELECT &&
-			    $type != ARTIFACT_EXTRAFIELDTYPE_CHECKBOX) {
-				/* text fields are just purged and skipped */
-				continue;
+				// but we got a value now
+
+				if (!preg_match('/^@/', $ef[$efid]['alias'])) {
+					$changes["extra_fields"][$efid] = 1;
+				}
+				$this->addHistory($ef[$efid]['field_name'],
+				    '(empty)');
 			}
 
 			//

Modified: trunk/gforge_base/evolvisforge-5.1/src/debian/changelog
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/debian/changelog	2012-10-04 09:58:03 UTC (rev 18681)
+++ trunk/gforge_base/evolvisforge-5.1/src/debian/changelog	2012-10-04 09:58:07 UTC (rev 18682)
@@ -21,8 +21,9 @@
   * [#3324] Add "Hours Worked" as display column
   * [#3228] Scroll overflows in item details
   * [#3209] Go back to Tracker Item after creating a Task Relation
+  * [#3191] Fix sending out tracker mails when a value is empty
 
- -- Thorsten Glaser <t.glaser at tarent.de>  Thu, 04 Oct 2012 10:33:48 +0200
+ -- Thorsten Glaser <t.glaser at tarent.de>  Thu, 04 Oct 2012 11:32:42 +0200
 
 fusionforge (1:5.1.1+evolvis70.1) unstable; urgency=high
 



More information about the evolvis-commits mailing list