[evolvis-commits] r18735: [#3230] Also remove projhtml.php export

mirabilos at evolvis.org mirabilos at evolvis.org
Mon Oct 29 15:08:51 CET 2012


Author: mirabilos
Date: 2012-10-29 15:08:48 +0100 (Mon, 29 Oct 2012)
New Revision: 18735

Removed:
   trunk/gforge_base/evolvisforge-5.1/src/www/export/projhtml.php
Modified:
   trunk/gforge_base/evolvisforge-5.1/src/debian/changelog
   trunk/gforge_base/evolvisforge-5.1/src/www/include/project_summary.php
Log:
[#3230] Also remove projhtml.php export

It was never used by us, is not linked, and if needed we can
reinstate AND FIX it; this is cheaper than fixing it now, as
it’s unneeded; it exhibits the same RBAC problem

Modified: trunk/gforge_base/evolvisforge-5.1/src/debian/changelog
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/debian/changelog	2012-10-29 14:08:39 UTC (rev 18734)
+++ trunk/gforge_base/evolvisforge-5.1/src/debian/changelog	2012-10-29 14:08:48 UTC (rev 18735)
@@ -9,8 +9,9 @@
   * Widgets: Revert collapsing project members by default, with the
     Codendi widget layout we’re flexible enough to keep the page fit
   * Widgets: [#3230] “Public Areas” ⇒ “Project Areas” (SECURITY fix)
+  * [#3230] Also remove projhtml.php export (unused, same bug)
 
- -- Thorsten Glaser <t.glaser at tarent.de>  Mon, 29 Oct 2012 14:54:31 +0100
+ -- Thorsten Glaser <t.glaser at tarent.de>  Mon, 29 Oct 2012 15:04:57 +0100
 
 fusionforge (1:5.1.1+evolvis74.2) unstable; urgency=high
 

Modified: trunk/gforge_base/evolvisforge-5.1/src/www/include/project_summary.php
===================================================================
--- trunk/gforge_base/evolvisforge-5.1/src/www/include/project_summary.php	2012-10-29 14:08:39 UTC (rev 18734)
+++ trunk/gforge_base/evolvisforge-5.1/src/www/include/project_summary.php	2012-10-29 14:08:48 UTC (rev 18735)
@@ -98,188 +98,3 @@
 function project_get_public_forum_message_count($group_id) {
 	return project_getaggvalue($group_id, 'fmsg');
 }
-
-/**
- * project_summary() - Build a project summary box that projects can insert into their project pages
- *
- * @param		int		The group ID
- * @param		string	How to return the results.
- * @param		bool	Whether to return the results within an HTML table or not
- */
-function project_summary($group_id,$mode,$no_table) {
-	if (!$group_id) {
-		return 'Error - No Project ID';
-	}
-	if (!$mode) {
-		$mode='full';
-	}
-
-	$project = group_get_object($group_id);
-
-	if (!$project || !is_object($project)) {
-		return 'Could Not Create Project Object';
-	} elseif ($project->isError()) {
-		return $project->getErrorMessage();
-	}
-
-	if (!$no_table) {
-		$return = '
-
-		<table border=0 width="100%"><tr><td class="tablecontent">';
-	}
-
-	// ################## ArtifactTypes
-
-	$return .= '<a href="'.util_make_url ('/tracker/?group_id='.$group_id).'">';
-	$return .= html_image("ic/tracker20g.png",'20','20',array('alt'=>'Tracker'));
-	$return .= ' Tracker</a>';
-
-	if ($mode != 'compact') {
-		$result=db_query_params ('SELECT agl.*,aca.count,aca.open_count
-		FROM artifact_group_list agl
-		LEFT JOIN artifact_counts_agg aca USING (group_artifact_id) 
-		WHERE agl.group_id=$1
-		AND agl.is_public=1
-		ORDER BY group_artifact_id ASC',
-			array($group_id));
-
-		$rows = db_numrows($result);
-	
-		if (!$result || $rows < 1) {
-			$return .= '<br /><em>'._('There are no public trackers available').'</em>';
-		} else {
-			for ($j = 0; $j < $rows; $j++) {
-				$return .= '<p>
-				 - '.util_make_link ('/tracker/?atid='. db_result($result, $j, 'group_artifact_id') . '&group_id='.$group_id.'&func=browse',db_result($result, $j, 'name'));
-				$return .= sprintf(ngettext('(<strong>%1$s</strong> open / <strong>%2$s</strong> total)', '(<strong>%1$s</strong> open / <strong>%2$s</strong> total)', (int) db_result($result, $j, 'open_count')), (int) db_result($result, $j, 'open_count'), (int) db_result($result, $j, 'count')) ;
-				$return .= '</p>';
-			}   
-		}
-	}
-
-	// ##################### Forums
-
-	if ($project->usesForum()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/forum/?group_id='.$group_id).'">';
-		$return .= html_image("ic/forum20g.png","20","20",array("alt"=>"Forums"));
-		$return .= ' Forums</a>';
-
-		if ($mode != 'compact') {
-			$return .= " ( <strong>". project_get_public_forum_message_count($group_id) ."</strong> messages in ";
-			$return .= "<strong>". project_get_public_forum_count($group_id) ."</strong> forums )\n";
-		}
-	}
-
-	// ##################### Doc Manager
-
-	if ($project->usesDocman()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/docman/?group_id='.$group_id).'">';
-		$return .= html_image("ic/docman16b.png","20","20",array("alt"=>"Docs"));
-		$return .= ' Doc Manager</a>';
-	}
-
-	// ##################### Mailing lists
-
-	if ($project->usesMail()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/mail/?group_id='.$group_id).'">';
-		$return .= html_image("ic/mail16b.png","20","20",array("alt"=>"Mail Lists"));
-		$return .= ' Mailing Lists</a>';
-
-		if ($mode != 'compact') {
-			$return .= " ( <strong>". project_get_mail_list_count($group_id) ."</strong> public lists )";
-		}
-	}
-
-	// ##################### Tasks
-
-	if ($project->usesPm()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/pm/?group_id='.$group_id).'">';
-		$return .= html_image("ic/taskman20g.png","20","20",array("alt"=>"Tasks"));
-		$return .= ' Task Manager</a>';
-
-		if ($mode != 'compact') {
-			//get a list of publicly available projects
-			$result = db_query_params ('SELECT * FROM project_group_list WHERE group_id=$1 AND is_public=1',
-						   array ($group_id));
-			$rows = db_numrows($result);
-			if (!$result || $rows < 1) {
-				$return .= '<br /><em>There are no public subprojects available</em>';
-			} else {
-				for ($j = 0; $j < $rows; $j++) {
-					$return .= '
-					<br />   - '.util_make_link ('/pm/task.php?group_project_id='.db_result($result, $j, 'group_project_id').'&group_id='.$group_id.'&func=browse',db_result($result, $j, 'project_name'));
-				}
-				db_free_result($result);
-			}
-		}
-	}
-
-	// ######################### Surveys 
-
-	if ($project->usesSurvey()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/survey/?group_id='.$group_id).'">';
-		$return .= html_image("ic/survey16b.png","20","20",array("alt"=>"Surveys"));
-		$return .= " Surveys</a>";
-		if ($mode != 'compact') {
-			$return .= ' ( <strong>'. project_get_survey_count($group_id) .'</strong> surveys )';
-		}
-	}
-
-	// ######################### SCM 
-
-	if ($project->usesSCM()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/scm/?group_id='.$group_id).'">';
-		$return .= html_image("ic/cvs16b.png","20","20",array("alt"=>"SCM"));
-		$return .= " SCM Tree</a>";
-
-		if ($mode != 'compact') {
-			$result = db_query_params ('SELECT SUM(commits) AS commits,SUM(adds) AS adds from stats_cvs_group where group_id=$1',
-						   array ($group_id));
-			$return .= ' ( <strong>'.db_result($result,0,0).'</strong> commits, <strong>'.db_result($result,0,1).'</strong> adds )';
-		}
-	}
-
-	// ######################## Released Files
-	
-	if ($project->isActive()) {
-		$return .= '
-
-			<hr size="1" />';
-		$return .= '<a href="'.util_make_url ('/project/showfiles.php?group_id='.$group_id).'">';
-		$return .= html_image("ic/ftp16b.png","20","20",array("alt"=>"FTP"));
-		$return .= " Released Files</a>";
-	}
-
-	if (!$no_table) {
-		$return .= '
-
-		</td></tr></table>';
-	}
-
-	return $return;
-}
-
-// Local Variables:
-// mode: php
-// c-file-style: "bsd"
-// End:
-
-?>



More information about the evolvis-commits mailing list